Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for ElementLineHermite #384

Closed
wants to merge 0 commits into from
Closed

Conversation

ahojukka5
Copy link
Contributor

Add test to make sure that exceptions are thrown when calling gdof with index > 3. After merging this PR, file element_line_hermite.py is having 100 % test coverage.

@ahojukka5
Copy link
Contributor Author

Internally, gdof is calling index_error which raises ValueError. Is this intentional?

@kinnala
Copy link
Owner

kinnala commented Jun 2, 2020

Internally, gdof is calling index_error which raises ValueError. Is this intentional?

Maybe IndexError would be more appropriate?

exception ValueError
Raised when an operation or function receives an argument that has the right type but an inappropriate value, and the situation is not described by a more precise exception such as IndexError.

exception IndexError
Raised when a sequence subscript is out of range.

@kinnala
Copy link
Owner

kinnala commented Jun 2, 2020

Note: Apparently the flake8 check I added using Github Actions yesterday is not running on pull requests. I need to look what's causing it.

@kinnala
Copy link
Owner

kinnala commented Jun 2, 2020

Now it runs but there seems to be an issue with the Github Action I used: wearerequired/lint-action#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants