Fixing constructor priority warning #177
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the original was intentional, feel free to delete this PR.
This section throws the following warning:
This comes from this definition:
According to C++ documentation, 0-100 is reserved for internal use.
However, in the commit that made this change Braden says it is to get around WASM bugs, so it may have been intentional.
I tried to find the WASM/emscripten error that would have prompted the change, but I couldn't find anything.
I did find documentation saying that emscripten uses a priority of 50, so it's possible 2 was chosen to beat that value.
I would test this to see what bugs appear, but I don't know what build configuration is being used for WASM.