fix: rare crash during entity join

Caused by improper use of synchronized fast map
klikli-dev · Aug 29, 2024 · 34af98b · 34af98b
1 parent bffbc85
commit 34af98b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/common/src/main/java/com/klikli_dev/modonomicon/data/BookDataManager.java b/common/src/main/java/com/klikli_dev/modonomicon/data/BookDataManager.java
@@ -51,7 +51,7 @@ public class BookDataManager extends SimpleJsonResourceReloadListener {
 
     private static final BookDataManager instance = new BookDataManager();
 
-    private Map<ResourceLocation, Book> books = Object2ObjectMaps.synchronize(new Object2ObjectOpenHashMap<>());
+    private final Map<ResourceLocation, Book> books = Object2ObjectMaps.synchronize(new Object2ObjectOpenHashMap<>());
     private boolean loaded;
     private boolean booksBuilt;
     private HolderLookup.Provider registries;
@@ -91,7 +91,7 @@ public boolean areBooksBuilt() {
 
     public void onDatapackSyncPacket(SyncBookDataMessage message) {
         this.preLoad();
-        this.books = Object2ObjectMaps.synchronize(new Object2ObjectOpenHashMap<>(message.books));
+        this.books.putAll(message.books);
         this.onLoadingComplete();
     }