fix: advancement condition tooltip bug

Closes #153
klikli-dev · Dec 1, 2023 · 5b364a8 · 5b364a8
1 parent 5a475f2
commit 5b364a8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/...on/src/main/java/com/klikli_dev/modonomicon/book/conditions/BookAdvancementCondition.java b/...on/src/main/java/com/klikli_dev/modonomicon/book/conditions/BookAdvancementCondition.java
@@ -33,7 +33,10 @@ public static BookAdvancementCondition fromJson(JsonObject json) {
 
         //default tooltip
         var tooltip = Component.translatable(Tooltips.CONDITION_ADVANCEMENT,
-                Component.translatable(Util.makeDescriptionId("advancement", advancementId) + ".title"));
+                Component.translatable(
+                        Util.makeDescriptionId("advancements", advancementId)
+                                .replace(".minecraft", "") //minecraft does not include the namespace in the id
+                                + ".title"));
 
         if (json.has("tooltip")) {
             tooltip = tooltipFromJson(json);

diff --git a/forge/src/generated/resources/.cache/cc4a2989348227984ebea88deca578b68e58344e b/forge/src/generated/resources/.cache/cc4a2989348227984ebea88deca578b68e58344e
diff --git a/forge/src/generated/resources/assets/modonomicon/lang/ru_ru.json b/forge/src/generated/resources/assets/modonomicon/lang/ru_ru.json