Skip to content

Guard Knative readiness predicates against failed reads - #2348

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
kahirokunn:guard-knative-readiness-predicates
Aug 27, 2026
Merged

Guard Knative readiness predicates against failed reads#2348
knative-prow[bot] merged 1 commit into
knative:mainfrom
kahirokunn:guard-knative-readiness-predicates

Conversation

@kahirokunn

Copy link
Copy Markdown
Member

Changes

  • Return API read errors before accessing KnativeServing or KnativeEventing status.

Release Note

NONE

@knative-prow
knative-prow Bot requested review from houshengbo and matzew August 26, 2026 05:46
@knative-prow knative-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 26, 2026
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.84%. Comparing base (71eefe9) to head (b2d8d06).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2348   +/-   ##
=======================================
  Coverage   65.84%   65.84%           
=======================================
  Files          56       56           
  Lines        2673     2673           
=======================================
  Hits         1760     1760           
  Misses        777      777           
  Partials      136      136           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kahirokunn

Copy link
Copy Markdown
Member Author

@dsimansk Hi ✋ PTAL. Thank you 🙏

@dsimansk

Copy link
Copy Markdown
Contributor

@kahirokunn can you rebase pls to get verify codegen passing?

@kahirokunn
kahirokunn force-pushed the guard-knative-readiness-predicates branch from e092572 to b2d8d06 Compare August 27, 2026 02:23
@kahirokunn

Copy link
Copy Markdown
Member Author

@kahirokunn can you rebase pls to get verify codegen passing?

Thank you. I fixed it 🙏

@dsimansk

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2026
@knative-prow

knative-prow Bot commented Aug 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, kahirokunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2026
@knative-prow
knative-prow Bot merged commit 7f45332 into knative:main Aug 27, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants