Gateio fix #4853
Gateio fix #4853
Conversation
| @@ -103,7 +103,7 @@ public GateioOrder toGateioOrder(MarketOrder marketOrder) { | |||
| return GateioOrder.builder() | |||
| .currencyPair((CurrencyPair) marketOrder.getInstrument()) | |||
| .side(marketOrder.getType()) | |||
| .clientOrderId(marketOrder.getUserReference()) | |||
| .clientOrderId("t-"+marketOrder.getUserReference()) | |||
There was a problem hiding this comment.
if you change the provided clientOrderId on the fly, then the library consumer can't find the order by original clientOrderId. IMHO it is a responsibility of a library consumer to generate the client ids in proper format
There was a problem hiding this comment.
You are correct, but if the client id is not specified, the order cannot be placed correctly
There was a problem hiding this comment.
according to api doc, field text in Order is optional: https://www.gate.io/docs/developers/apiv4/en/#create-an-order
I also just verified it manually
| @@ -116,7 +116,7 @@ public GateioOrder toGateioOrder(LimitOrder limitOrder) { | |||
| return GateioOrder.builder() | |||
| .currencyPair((CurrencyPair) limitOrder.getInstrument()) | |||
| .side(limitOrder.getType()) | |||
| .clientOrderId(limitOrder.getUserReference()) | |||
| .clientOrderId("t-"+limitOrder.getUserReference()) | |||
There was a problem hiding this comment.
if you change the provided clientOrderId on the fly, then the library consumer can't find the order by original clientOrderId. IMHO it is a responsibility of a library consumer to generate the client ids in proper format
| @@ -147,8 +147,12 @@ public Order toOrder(GateioOrder gateioOrder) { | |||
| builder.cumulativeAmount(gateioOrder.getFilledTotalQuote()); | |||
| } | |||
| else if (orderType == OrderType.ASK) { | |||
| BigDecimal filledAssetAmount = gateioOrder.getFilledTotalQuote().divide(gateioOrder.getAvgDealPrice(), MathContext.DECIMAL32); | |||
| builder.cumulativeAmount(filledAssetAmount); | |||
| if(gateioOrder.getAvgDealPrice()==null||gateioOrder.getFilledTotalQuote()==null){ | |||
There was a problem hiding this comment.
please format with spaces
| @@ -16,12 +16,13 @@ public class GateioStreamingExchange extends GateioExchange implements Streaming | |||
| private StreamingMarketDataService streamingMarketDataService; | |||
| private StreamingTradeService streamingTradeService; | |||
| private StreamingAccountService streamingAccountService; | |||
| public static final String WS_CHANNEL_URI = "wss://api.gateio.ws/ws/v4/"; | |||
There was a problem hiding this comment.
why moving the url from config?
| @@ -13,7 +13,7 @@ | |||
| @Data | |||
| public final class Config { | |||
|
|
|||
| public static final String V4_URL = "wss://api.gateio.ws/ws/v4/"; | |||
| public static final String V4_URL = "https://api.gateio.ws/"; | |||
There was a problem hiding this comment.
this url is used for rest calls
There was a problem hiding this comment.
rest api cannot be called normally
There was a problem hiding this comment.
you don't have to do REST calls from xchange-stream-gateio module, all rest calls are done in xchange-gateio-v4 or xchange-gateio modules
| @@ -94,7 +94,7 @@ public OrderBook toOrderBook(GateioOrderBookNotification notification) { | |||
| Stream<LimitOrder> asks = orderBookPayload.getAsks().stream() | |||
| .map(priceSizeEntry -> new LimitOrder(OrderType.ASK, priceSizeEntry.getSize(), orderBookPayload.getCurrencyPair(), null, null, priceSizeEntry.getPrice())); | |||
|
|
|||
| Stream<LimitOrder> bids = orderBookPayload.getAsks().stream() | |||
| Stream<LimitOrder> bids = orderBookPayload.getBids().stream() | |||
There was a problem hiding this comment.
that's a good catch 👍 I'll change the test to check it and fix it in PR
Fix known issues such as failed api calls