Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[general] Remove method implementation that just throw exception #4875

Merged
merged 3 commits into from
May 22, 2024

Conversation

bigscoop
Copy link
Contributor

@bigscoop bigscoop commented May 9, 2024

  • Removed empty method implementations that just throw NotYetImplementedForExchangeException because it is already thrown in default method in corresponding interface

@timmolter I don't expect any breaking changes here, but you never know... That's why I propose merging it after the release 5.1.2

@timmolter timmolter merged commit 0b77a88 into knowm:develop May 22, 2024
1 check passed
@timmolter
Copy link
Member

just going to merge it now...

@bigscoop bigscoop deleted the code-cleanup branch June 5, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants