Provide key in IsDeleted delegate to support TTL based on keys #253
koculuAnnotations
11 warnings
|
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-dotnet@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
build:
src/ZoneTree/Segments/Disk/CircularCache.cs#L25
Member 'statsCacheHit' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)
|
|
build:
src/ZoneTree/Segments/Disk/CircularCache.cs#L27
Member 'statsCacheMiss' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)
|
|
build:
src/ZoneTree/Core/ZoneTreeMaintainer.cs#L41
Member 'ThresholdForMergeOperationStart' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)
|
|
build:
src/ZoneTree/Serializers/UnicodeStringSerializer.cs#L14
Member 'Deserialize' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
|
build:
src/ZoneTree/Segments/RandomAccess/FileRandomAccessDevice.cs#L62
In member Memory<byte> FileRandomAccessDevice.GetBytes(long offset, int length, SingleBlockPin pin), change parameter name pin to blockPin in order to match the identifier as it has been declared in Memory<byte> IRandomAccessDevice.GetBytes(long offset, int length, SingleBlockPin blockPin = null) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
|
|
build:
src/ZoneTree/Segments/Disk/CircularCache.cs#L29
Use properties where appropriate (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1024)
|
|
build:
src/ZoneTree/Segments/DiskSegmentVariations/VariableSizeDiskSegment.cs#L153
In member TKey VariableSizeDiskSegment<TKey, TValue>.ReadKey(long index, BlockPin blockPin), change parameter name blockPin to pin in order to match the identifier as it has been declared in TKey DiskSegment<TKey, TValue>.ReadKey(long index, BlockPin pin) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
|
|
build:
src/ZoneTree/Segments/DiskSegmentVariations/FixedSizeValueDiskSegment.cs#L147
In member TKey FixedSizeValueDiskSegment<TKey, TValue>.ReadKey(long index, BlockPin blockPin), change parameter name blockPin to pin in order to match the identifier as it has been declared in TKey DiskSegment<TKey, TValue>.ReadKey(long index, BlockPin pin) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
|
|
build:
src/ZoneTree/Segments/DiskSegmentVariations/FixedSizeValueDiskSegment.cs#L181
In member TValue FixedSizeValueDiskSegment<TKey, TValue>.ReadValue(long index, BlockPin blockPin), change parameter name blockPin to pin in order to match the identifier as it has been declared in TValue DiskSegment<TKey, TValue>.ReadValue(long index, BlockPin pin) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
|
|
build:
src/ZoneTree/Segments/DiskSegmentVariations/VariableSizeDiskSegment.cs#L186
In member TValue VariableSizeDiskSegment<TKey, TValue>.ReadValue(long index, BlockPin blockPin), change parameter name blockPin to pin in order to match the identifier as it has been declared in TValue DiskSegment<TKey, TValue>.ReadValue(long index, BlockPin pin) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
|