issue-1249: entitlements cert not working using buildah task with support for activation keys #1269
Conversation
konflux-ci#1249 When an activation key is not provided, Kubernetes still mounts a volume. This volume is also not truly empty but contains some symlinks in it. To ensure that the fallback to mounted certificates works for backwards compatibility, activation keys will only be mounted now if the 'org' key is present in the key/value secret. This is tested by checking for a file-like-object (-e) in the dir where the secret is mounted.
|
I have no issue with this pull request but I cannot comment on the technical details of it as I don't have experience with activation keys. Do we have documentation for activation keys that indicate the required org key? I assume that this is more of a bug fix than a breaking change so no version bump would be needed. |
|
this is indeed a bugfix. I have tested it pretty thoroughly. Without this fix anyone mounting entitlement certificates will see PR failures on newer versions of the buildah task. I am holding off on posting activation keys docs (but I have a draft) because there is a chance that there will be a follow up PR to move the 'subscription-manager register' command into a STEP script so that it is not required to be in the Dockerfile. This is being asked for by a number of people already. I have a meeting to discuss it with another team this coming week. I'd like to minimize the number of people who need to make yet another change to how they obtain content access. |
|
/retest |
closes #1249
When an activation key secret is not provided, Kubernetes still mounts a volume. This volume is also not truly empty but contains some symlinks in it. To ensure that the fallback to mounted certificates works for backwards compatibility, activation keys will only be mounted now if the 'org' key is present in the key/value secret. This is tested by checking for a file-like-object (-e) in the dir where the secret is mounted.
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.