Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace grep base images parsing with dockerfile-json #1304

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Replace grep base images parsing with dockerfile-json #1304

merged 1 commit into from
Sep 3, 2024

Commits on Aug 29, 2024

  1. Replace grep base images parsing with dockerfile-json 

    This is more reliable and allow us to fix bugs where base images were
loaded incorrectly.

For example, previously this part in Dockerfile:

LABEL description="this is a build \
                   from single-arch"

Would return "single-arch" as a base image.

Using dockerfile-json also solves the problem of omitting "scratch" from
the results.

Another advantage is that when we have something such as:

FROM registry.access.redhat.com/ubi9/ubi:latest as builder
...
FROM builder AS build1

then only the original image
"registry.access.redhat.com/ubi9/ubi:latest" will be reported.

KFLUXBUGS-1269

Signed-off-by: mkosiarc <mkosiarc@redhat.com>
    @mkosiarc
    mkosiarc committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    c23c0cb View commit details
    Browse the repository at this point in the history