Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: GPU Partition related #2219

Merged

Conversation

ZiMengSheng
Copy link
Contributor

@ZiMengSheng ZiMengSheng commented Oct 8, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.20%. Comparing base (0466bf3) to head (6c6b92e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2219      +/-   ##
==========================================
+ Coverage   67.18%   67.20%   +0.01%     
==========================================
  Files         451      451              
  Lines       43480    43480              
==========================================
+ Hits        29214    29221       +7     
+ Misses      11718    11714       -4     
+ Partials     2548     2545       -3     
Flag Coverage Δ
unittests 67.20% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZiMengSheng ZiMengSheng force-pushed the ppu16_partition_protocol branch 2 times, most recently from 27fd132 to 1ce08a3 Compare October 8, 2024 08:08
@ZiMengSheng ZiMengSheng force-pushed the ppu16_partition_protocol branch 4 times, most recently from 34035c0 to 73d8ac5 Compare October 8, 2024 10:08
@ZiMengSheng ZiMengSheng force-pushed the ppu16_partition_protocol branch 2 times, most recently from d083273 to 3688cfd Compare October 8, 2024 12:30
@songtao98
Copy link
Contributor

/lgtm

apis/extension/device_share.go Outdated Show resolved Hide resolved
apis/extension/device_share.go Outdated Show resolved Hide resolved
docs/proposals/scheduling/20241008-gpu-partition-api.md Outdated Show resolved Hide resolved
docs/proposals/scheduling/20241008-gpu-partition-api.md Outdated Show resolved Hide resolved
docs/proposals/scheduling/20241008-gpu-partition-api.md Outdated Show resolved Hide resolved
docs/proposals/scheduling/20241008-gpu-partition-api.md Outdated Show resolved Hide resolved
@ZiMengSheng ZiMengSheng force-pushed the ppu16_partition_protocol branch 2 times, most recently from 61ea70b to 95afb5e Compare October 9, 2024 10:05
@saintube
Copy link
Member

/lgtm

@saintube saintube added the lgtm label Oct 10, 2024
@ZiMengSheng ZiMengSheng force-pushed the ppu16_partition_protocol branch 3 times, most recently from 4ab0439 to 4c1ec4f Compare October 11, 2024 14:19
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
@ZiMengSheng
Copy link
Contributor Author

/approve

@koordinator-bot koordinator-bot bot merged commit fe65fc9 into koordinator-sh:main Oct 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants