Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Custom activity support to PresenceBuilder #984

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions gateway/src/commonMain/kotlin/builder/PresenceBuilder.kt
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ public class PresenceBuilder {
public fun competing(name: String) {
game = DiscordBotActivity(name, ActivityType.Competing)
}

public fun custom(name: String) {
game = DiscordBotActivity(name, ActivityType.Custom)
}
Comment on lines +42 to +44
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public fun custom(name: String) {
game = DiscordBotActivity(name, ActivityType.Custom)
}
public fun custom(state: String) {
game = null
this.state = state
}

see #857 (review) for why this should be implemented this way



private fun buildGame(): DiscordBotActivity? {
val game = game
Expand Down
Loading