KTOR-7586: improve parsing of supported media types #4410
Conversation
| application/java-byte-code,class | ||
| application/java-serialized-object,ser | ||
| application/java-vm,class | ||
| application/javascript,js |
There was a problem hiding this comment.
Media type application/javascript is obsolete, so it should have lesser priority than text/javascript, but all application/ media types now have priority over text/ types as they're upper in the list. Our tests have detected this change and WebjarsTest fails with the message: expected: <text/javascript> but was: <application/javascript>.
A simple solution is to move all deprecated types to the bottom of the list after some separator
...
text/json
...
# Deprecated media types
application/json
While this solution works well for changing the priority of deprecated types, we might have other inconsistencies between old and new order (like with .rpm extension). Could you write down all inconsistencies?
There was a problem hiding this comment.
after some separator
are you suggesting to insert a comment into rawMimes and ignore it when processing the string?
There was a problem hiding this comment.
Yes, we could ignore lines starting with # in addition to already ignored empty lines
good points, thanks, please review the fixes |
Subsystem
Core, http
Motivation
https://youtrack.jetbrains.com/issue/KTOR-7586
Solution
improved parsing of supported media types