-
Notifications
You must be signed in to change notification settings - Fork 441
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[GSoC] Compatibility Changes in Trial Controller (#2394)
* chore: add condition branch in requeue logic. Signed-off-by: Electronic-Waste <2690692950@qq.com> * chore: add ReportObservationLog in katib_manager_util.go. Signed-off-by: Electronic-Waste <2690692950@qq.com> * chore: add ReportTrialUnavailableMetrics func. Signed-off-by: Electronic-Waste <2690692950@qq.com> * chore: insert unavailable value into Katib DB. Signed-off-by: Electronic-Waste <2690692950@qq.com> * fix: fix lint error. Signed-off-by: Electronic-Waste <2690692950@qq.com> * fix: add nil condition judgement. Signed-off-by: Electronic-Waste <2690692950@qq.com> * fix: add nil condition judgement in trial_controller_util.go Signed-off-by: Electronic-Waste <2690692950@qq.com> * chore(trial): delete nil check of MC kind in the Trial controller. Signed-off-by: Electronic-Waste <2690692950@qq.com> * chore(trial): init MC in newFakeTrialBatchJob to avoid nil condition in trial reconcile loop. Signed-off-by: Electronic-Waste <2690692950@qq.com> * fix(trial): fix lint error. Signed-off-by: Electronic-Waste <2690692950@qq.com> * fix(trial): fix lint error in controller. Signed-off-by: Electronic-Waste <2690692950@qq.com> * test(trial): add integration test for Push MC. Signed-off-by: Electronic-Waste <2690692950@qq.com> * chore(trial): retry reconcilation when reporting unavailable metrics failed. Signed-off-by: Electronic-Waste <2690692950@qq.com> * test(trial): fix EXPECT order. Signed-off-by: Electronic-Waste <2690692950@qq.com> * test(trial): fix typo error. Signed-off-by: Electronic-Waste <2690692950@qq.com> * chore(trial): add errReportMetricsFailed. Signed-off-by: Electronic-Waste <2690692950@qq.com> * Update pkg/controller.v1beta1/trial/trial_controller.go Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Electronic-Waste <2690692950@qq.com> * Update pkg/controller.v1beta1/trial/trial_controller_util.go Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: Electronic-Waste <2690692950@qq.com> * Update pkg/controller.v1beta1/trial/trial_controller.go Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: Electronic-Waste <2690692950@qq.com> * fix(trial): rename errors pkg. Signed-off-by: Electronic-Waste <2690692950@qq.com> * test(trial): update the order of UT. Signed-off-by: Electronic-Waste <2690692950@qq.com> * test(trial): use different names for UTs. Signed-off-by: Electronic-Waste <2690692950@qq.com> * test(trial): separate Push MC UTs with original UTs. Signed-off-by: Electronic-Waste <2690692950@qq.com> * test(trial): fix line error with gofmt. Signed-off-by: Electronic-Waste <2690692950@qq.com> * test(trial): reserve one UT for Push MC. Signed-off-by: Electronic-Waste <2690692950@qq.com> * test(trial): fix typo error. Signed-off-by: Electronic-Waste <2690692950@qq.com> * test(trial): make some tiny changes. Signed-off-by: Electronic-Waste <2690692950@qq.com> * fix(trial): move cancel func to t.Cleanup. Signed-off-by: Electronic-Waste <2690692950@qq.com> * fix(trial): use the propagated gomega instance to improve debuggability. Signed-off-by: Electronic-Waste <2690692950@qq.com> * fix(trial): use gofmt to reformat code. Signed-off-by: Electronic-Waste <2690692950@qq.com> --------- Signed-off-by: Electronic-Waste <2690692950@qq.com> Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
- Loading branch information
1 parent
bc09cfd
commit 867c40a
Showing
6 changed files
with
198 additions
and
75 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.