-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.27.2 #2344
Release 1.27.2 #2344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
hmm, just thinking why cinder test is failing. It works in master + release-1.28 currently |
/test openstack-cloud-csi-cinder-e2e-test-release-127 1.27 used to be working I think ? |
yeah it was working in #2311 but it might be that its broken in release-1.27 itself. Maybe worth of testing in another PR? |
Let's see #2349 then. |
@zetaab: I just had a moment to take a closer look at the job failure. Looks like the 1.27.2 image is not available and that's why it fails:
Could it be because I cannot tag this as 1.27.2 and the images are not in staging? What's the procedure there? |
@@ -9,4 +9,4 @@ run_e2e: false | |||
# Used for access the private registry image from k8s | |||
remote_registry_host: "{{ ansible_default_ipv4.address }}" | |||
generated_image_url: "{{ remote_registry_host }}/openstack-cloud-controller-manager:v0.0.{{ github_pr }}" | |||
image_url: "{{ generated_image_url if build_image else 'registry.k8s.io/provider-os/openstack-cloud-controller-manager:v1.27.1' }}" | |||
image_url: "{{ generated_image_url if build_image else 'registry.k8s.io/provider-os/openstack-cloud-controller-manager:v1.27.2' }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah the problem is coming from this row, the cinder e2e test does not build the image - instead tries to use image that does not exist yet. It is kind of chicken - egg problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2351 this tries to fix this issue.
I've rebased this to include #2352, let's see now. |
It went through! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc, zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This releases 1.27.2 bugfix release.
Release note: