Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.27.2 #2344

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Release 1.27.2 #2344

merged 2 commits into from
Aug 30, 2023

Conversation

dulek
Copy link
Contributor

@dulek dulek commented Aug 28, 2023

What this PR does / why we need it:
This releases 1.27.2 bugfix release.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 28, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 28, 2023
zetaab
zetaab requested changes Aug 29, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 29, 2023
zetaab
zetaab approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2023
@zetaab
Copy link
Member

zetaab commented Aug 29, 2023

hmm, just thinking why cinder test is failing. It works in master + release-1.28 currently

@jichenjc
Copy link
Contributor

/test openstack-cloud-csi-cinder-e2e-test-release-127

1.27 used to be working I think ?

@zetaab
Copy link
Member

zetaab commented Aug 29, 2023 •
edited
Loading

yeah it was working in #2311

but it might be that its broken in release-1.27 itself. Maybe worth of testing in another PR?

@dulek
Copy link
Contributor Author

dulek commented Aug 29, 2023

Let's see #2349 then.

@dulek
Copy link
Contributor Author

dulek commented Aug 29, 2023 •
edited
Loading

@zetaab: I just had a moment to take a closer look at the job failure. Looks like the 1.27.2 image is not available and that's why it fails:

Image:      registry.k8s.io/provider-os/openstack-cloud-controller-manager:v1.27.2",

Error from server (BadRequest): container "openstack-cloud-controller-manager" in pod "openstack-cloud-controller-manager-b9575fdc6-js89h" is waiting to start: trying and failing to pull image

Could it be because I cannot tag this as 1.27.2 and the images are not in staging? What's the procedure there?

zetaab
zetaab reviewed Aug 29, 2023
View reviewed changes
tests/playbooks/roles/install-cpo-occm/defaults/main.yaml
@@ -9,4 +9,4 @@ run_e2e: false
# Used for access the private registry image from k8s
remote_registry_host: "{{ ansible_default_ipv4.address }}"
generated_image_url: "{{ remote_registry_host }}/openstack-cloud-controller-manager:v0.0.{{ github_pr }}"
image_url: "{{ generated_image_url if build_image else 'registry.k8s.io/provider-os/openstack-cloud-controller-manager:v1.27.1' }}"
image_url: "{{ generated_image_url if build_image else 'registry.k8s.io/provider-os/openstack-cloud-controller-manager:v1.27.2' }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah the problem is coming from this row, the cinder e2e test does not build the image - instead tries to use image that does not exist yet. It is kind of chicken - egg problem.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2351 this tries to fix this issue.

@dulek
Copy link
Contributor Author

dulek commented Aug 29, 2023

I've rebased this to include #2352, let's see now.

@dulek
Copy link
Contributor Author

dulek commented Aug 29, 2023

It went through!

@jichenjc
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 91cd925 into kubernetes:release-1.27 Aug 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetaab zetaab zetaab approved these changes

@jichenjc jichenjc Awaiting requested review from jichenjc

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dulek @zetaab @jichenjc @k8s-ci-robot