Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle broken mappings that are part of a plan (error when editing, prevent migrating) #136

Closed
mturley opened this issue May 10, 2021 · 6 comments
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone

Comments

@mturley
Copy link
Contributor

mturley commented May 10, 2021

Noticed when trying to fix https://bugzilla.redhat.com/show_bug.cgi?id=1958649 in kubev2v/forklift-ui#591. There is a possibility that if the wizard's prefill effect can't find mapping source/target resources matching the mapping CR embedded in the plan, it will fail to prefill those values and the mapping steps will use defaults (acting as if you're creating a new plan). We should detect these missing items and report an error of some kind on the mapping step, indicating that the mapping present originally can't be used, so it has reverted to defaults. We should also make sure a plan with broken mappings associated causes a condition on both the mapping CR and the plan CR. We already handle this for shared mappings on the mappings page using the isMappingValid helper which could be reused, but we should make sure the plan is blocked from migrating in this case too.

@mturley mturley changed the title Gracefully handle broken mappings that are part of a plan when editing a plan Gracefully handle broken mappings that are part of a plan (error when editing, prevent migrating) May 10, 2021
@mturley mturley assigned mturley and unassigned mturley Jun 30, 2021
@yaacov yaacov transferred this issue from kubev2v/forklift-ui Jan 12, 2023
@yaacov yaacov added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Jan 12, 2023
@github-actions
Copy link

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label May 14, 2023
@github-actions
Copy link

This issue was closed because it has been stalled for 15 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2023
@yaacov yaacov reopened this May 29, 2023
@yaacov yaacov removed the Stale label May 29, 2023
@github-actions
Copy link

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Sep 27, 2023
@yaacov yaacov removed the Stale label Sep 27, 2023
Copy link

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Jan 26, 2024
@yaacov yaacov removed the Stale label Jan 26, 2024
@yaacov
Copy link
Member

yaacov commented Jan 26, 2024

part of: #801

@yaacov yaacov added this to the next milestone Feb 12, 2024
@yaacov yaacov modified the milestones: next, 2.7.0 Mar 25, 2024
@yaacov
Copy link
Member

yaacov commented Apr 2, 2024

addressed by #801 and #966

@yaacov yaacov closed this as completed Apr 2, 2024
@yaacov yaacov modified the milestones: 2.7.0, 2.6.0 Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

2 participants