This repository has been archived by the owner on Jan 12, 2023. It is now read-only.
[Backport] Fix BZ#1958649 and BZ#1958652: Use correct query when looking up storage mappings for prefilling wizard in edit mode (#591) #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed Preview: http://konveyor-forklift-ui-pr-592-preview.surge.sh ✨ Compare with current main branch: http://konveyor-forklift-ui-preview.surge.sh |
mturley
force-pushed
the
release-v2.0.0-bz1958649-and-1958652
branch
from
785ea07
to
3843d2f
Compare
Codecov Report
@@ Coverage Diff @@
## release-v2.0.0 kubev2v/forklift-ui#592 +/- ##
==================================================
- Coverage 59.96% 59.68% -0.29%
==================================================
Files 137 137
Lines 4396 4395 -1
Branches 1203 1198 -5
==================================================
- Hits 2636 2623 -13
- Misses 1727 1739 +12
Partials 33 33
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
ghost
approved these changes
May 10, 2021
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #591.
Note: this PR includes additional changes related to these bugs, since I happened to fix part of it on the main branch in #585. The commit 785ea07 replicates the changes from 406b098#diff-55b411ad333b40962073e7eb43e4f9db265aaada61377172a4e4b5e98384ec07R163-R185 in order to properly prevent the user from opening wizard steps that depend on earlier steps with invalid values. This means if the mappings are somehow still invalid after prefilling even with these fixes, the user will be forced to visit those steps and fix the mappings before proceeding. See https://github.com/konveyor/forklift-ui/issues/590.