Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐾 Add a fast Create Plan page - step 3 #855

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

rszwajko
Copy link
Contributor

Changes:

  1. split state into slices
  2. split reducer.tx - move state helper functions
  3. improve typings for multus network type
  4. create hooks to retrieve nic profiles and networks from the inventory
  5. create a MappingList component for editing mappings
  6. re-create state only when input queries are fully loaded
  7. display source networks in 2 categories: networks used by the selected VMs and remaining networks on the provider
  8. create network mapping based on information in the state

Initial state

Note:

  1. links to mappings are non-clickable because the mappings are not created yet
  2. the visible mapping is the only network used by the selected VMs mapped to the default network (Pod Networking)
  3. add mapping button is active - it's possible to add any source network present on the provider
    Screenshot from 2024-01-29 17-35-11

Select with available source networks

Screenshot from 2024-01-29 17-35-30

Select with available target networks

Screenshot from 2024-01-29 17-35-48

UI after the network mapping is created

Note:

  1. the resource link is active
  2. it's not possible to edit the mappings

Screenshot from 2024-01-29 17-36-20

Changes:
1. split state into slices
2. split reducer.tx - move state helper functions
3. improve typings for multus network type
4. create hooks to retrieve nic profiles and networks from the inventory
5. create a MappingList component for editing mappings
6. re-create state only when input queries are fully loaded
7. display source networks in 2 categories: networks used by the
   selected VMs and remaining networks on the provider
8. create network mapping based on information in the state

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rszwajko rszwajko marked this pull request as ready for review January 29, 2024 17:38
@yaacov yaacov added the enhancement Categorizes issue or PR as related to a new feature. label Jan 29, 2024
@yaacov yaacov changed the title Add a fast Create Plan page - step 3 🐾 Add a fast Create Plan page - step 3 Jan 29, 2024
@yaacov yaacov added this to the 2.6.0 milestone Jan 29, 2024
@yaacov yaacov merged commit 3670aa5 into kubev2v:main Jan 29, 2024
7 checks passed
@rszwajko
Copy link
Contributor Author

Implements #801

@yaacov yaacov added the plans label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Categorizes issue or PR as related to a new feature. plans
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants