Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐾 Add a fast Create Plan page - step 4 #875

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

rszwajko
Copy link
Contributor

Implements #801

Changes:

  1. create plan flow implemented via promise chain (storage mapping is still empty)
  2. move fetch/save effects to hooks
  3. add loading indicator based on editDone/apiError flags
  4. implement actions for adding/removing/replacing network mappings
  5. use namespace from the source provider - follow-up after switching to RoutePage extension

Changes:
1. create plan flow implemented via promise chain (storage mapping is
   still empty)
2. move fetch/save effects to hooks
3. add loading indicator based on editDone/apiError flags
4. implement actions for adding/removing/replacing network mappings
5. use namespace from the source provider - follow-up after switching to
   RoutePage extension

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rszwajko rszwajko marked this pull request as ready for review January 31, 2024 17:31
@yaacov yaacov merged commit f5c19d2 into kubev2v:main Jan 31, 2024
7 checks passed
@yaacov yaacov changed the title Add a fast Create Plan page - step 4 🐾 Add a fast Create Plan page - step 4 Jan 31, 2024
@yaacov yaacov added the enhancement Categorizes issue or PR as related to a new feature. label Jan 31, 2024
@yaacov yaacov added this to the 2.6.0 milestone Jan 31, 2024
@yaacov yaacov added the plans label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Categorizes issue or PR as related to a new feature. plans
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants