Develop #24
Develop #24
Conversation
| @@ -33,6 +33,13 @@ android { | |||
| } | |||
|
|
|||
| dependencies { | |||
| implementation 'androidx.legacy:legacy-support-v4:1.0.0' | |||
| def nav_version = "2.3.1" | |||
There was a problem hiding this comment.
this should move to the project level gradle
| savedInstanceState: Bundle? | ||
| ): View? { | ||
| // Inflate the layout for this fragment | ||
| return inflater.inflate(R.layout.fragment_onboarding, container, false) |
There was a problem hiding this comment.
we are using viewbinding instead
| // supportActionBar?.hide() | ||
|
|
||
| Handler().postDelayed({ | ||
| navController!!.navigate(R.id.action_splashScreenFragment_to_onboardingFragment) |
There was a problem hiding this comment.
!! causes null pointer exception should be replaced with ? and also we are using safeargs for navigation to avoid runtime error which I already added the dependency
| app:layout_constraintBottom_toTopOf="@id/indicatorsContainer" | ||
| android:layout_marginBottom="12dp"/> | ||
| </androidx.constraintlayout.widget.ConstraintLayout> | ||
| </FrameLayout> |
There was a problem hiding this comment.
their is no need for framelayout lets maintain only constraint when there are more than one child view
| android:layout_height="match_parent" | ||
| tools:context=".SplashScreenFragment"> | ||
|
|
||
| <androidx.constraintlayout.widget.ConstraintLayout |
There was a problem hiding this comment.
this is best an imageView, we should avoid nested parent views
| xmlns:app="http://schemas.android.com/apk/res-auto" | ||
| xmlns:tools="http://schemas.android.com/tools" | ||
| android:id="@+id/nav_graph" | ||
| app:startDestination="@id/onboardingFragment"> |
There was a problem hiding this comment.
this should be splashfragment instead
| android:layout_height="wrap_content" | ||
| android:gravity="center" | ||
| android:orientation="horizontal" | ||
| app:layout_constraintBottom_toTopOf="@id/buttonNext" /> |
There was a problem hiding this comment.
also its best we use a library for indicator which I already added
| android:id="@+id/introSliderViewPager" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="0dp" | ||
| android:overScrollMode="never" |
There was a problem hiding this comment.
this is not advisable, it should be removed
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| app:layout_constraintBottom_toTopOf="@+id/textSkipIntro" | ||
| android:minWidth="110dp" |
There was a problem hiding this comment.
I dont know the reason for this minWidth dont think its necessary
| android:id="@+id/buttonNext" | ||
| android:textSize="14sp" | ||
| android:textStyle="bold" | ||
| android:layout_marginBottom="10dp" |
There was a problem hiding this comment.
always add sizes to dimens file to avoid repetition, you will see a sample with what I have done
I added the navigation_graph and fragments for the splash screen and onboarding screen