Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The operations of creating the secret and attachedcluster are moved to the suite_test #599

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

LiZhenCheng9527
Copy link
Contributor

What this PR does / why we need it:
The creation of secrets and attachedclusters operations have been moved to suite_test. This allows fleets to be created with randomized namespaces so that fleet-related tests can run concurrently.
Which issue(s) this PR fixes:
a part of #436

Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for kurator-dev canceled.

Name Link
🔨 Latest commit 375e8e7
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/65c0467057786400082392c9

…o the suite_test

Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurator-bot kurator-bot merged commit 386cab0 into kurator-dev:main Feb 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants