Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ApplyApiRule func to respect version of APIRule #1381

Merged
merged 14 commits into from
Oct 18, 2024
Merged

Fix ApplyApiRule func to respect version of APIRule #1381

merged 14 commits into from
Oct 18, 2024

Conversation

videlov
Copy link
Collaborator

@videlov videlov commented Oct 15, 2024 •
edited by triffer
Loading

Description

Changes proposed in this pull request:

  • Fix ApplyApiRule func to respect version of APIRule

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 15, 2024
@videlov videlov marked this pull request as ready for review October 15, 2024 08:49
@videlov videlov requested a review from a team as a code owner October 15, 2024 08:49
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2024
triffer
triffer reviewed Oct 16, 2024
View reviewed changes
tests/integration/pkg/helpers/api_rule.go Outdated Show resolved Hide resolved
tests/integration/pkg/helpers/api_rule.go Outdated Show resolved Hide resolved
tests/integration/pkg/helpers/api_rule.go Outdated Show resolved Hide resolved
@videlov videlov requested a review from triffer October 16, 2024 10:26
@triffer
Change ApplyApiRule to verify the status by respecting that APIRule h…
ae59cc0 
…as no status set for some time after creation.
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 18, 2024
@triffer triffer merged commit 943bdd1 into kyma-project:main Oct 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolodziejczak kolodziejczak kolodziejczak approved these changes

@triffer triffer Awaiting requested review from triffer

Assignees

@kolodziejczak kolodziejczak

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@videlov @triffer @kolodziejczak @kyma-bot