Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking PR code in upgrade tests #586

Conversation

jaroslaw-pieszka
Copy link
Contributor

Description

Changes proposed in this pull request:

  • If it is a post job (PullRequestEvent) we checkout code from PR head

Related issue(s)

triffer and others added 29 commits September 4, 2023 11:58
* Add scaffolding of APIGateway

* Adapt kubebuilder project name and add commonLabels

* Rename default cr

* Adapt makefile and remove config that is not required.

* Fix envtest suite config

* Remove .env for now

* Exclude ORY integration tests, add priority class and move license info

* APIGateway controller updates CR status to ready

* Fix integration tests

* Remove unuser files and add overview diagram

* Make istio JWT handler the default and remove config map

* Simplify flags

* Remove Ory JWT envtest tests

* Add RateLimiter, remove problematic configmap code and add all status of APIGateway and status description.

* Remove status test description and remove empty spec on default APIGateway

* Adapt rate limit creation and docs

* Revert configmap handling

* Revert import changes to reduce amount of changes for review and revert accidentally committed apirule crd

* Add missing startup param to doc

* Fix linting issues

* Add scripts to start api-gateway with lifecycle-manager locally

* Adapt script that checks local deployment status to use the correct resource

* Revert removal of LICENSES folder

* Update apis/operator/v1alpha1/apigateway_types.go

Co-authored-by: Bartosz Chwila <103247439+barchw@users.noreply.github.com>

* Updated generated manifest

* Update config/samples/operator_v1alpha1_apigateway.yaml

Co-authored-by: Bartosz Chwila <103247439+barchw@users.noreply.github.com>

* Update hack/verify_kyma_status.sh

Co-authored-by: Bartosz Chwila <103247439+barchw@users.noreply.github.com>

---------

Co-authored-by: Marek Kolodziejczak <marek.kolodziejczak@sap.com>
Co-authored-by: Bartosz Chwila <103247439+barchw@users.noreply.github.com>
* Remove api-gateway-config cm so it's not reconciled by lifecycle-manager.
Add basic testenv integrationtest for gateway controller.

* Update controller suite names
* Restructure documentation

* Add APIRule reconciliation sequence diagram

* Update APIRule reconciliation sequence diagram

* Update APIRule reconciliation sequence diagram

* Update APIRule reconciliation sequence diagram

* Add contributor operator SKR overview

* Add first version of the technical design

* Update operator overview diagram

* Add ADR link

* Apply suggestions from code review

Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>

* Update docs structure and add DNSProvider to overview diagram

---------

Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>
* Create API-Gateway-CRD-proposal.md

* Update API-Gateway-CRD-proposal.md

* Update API-Gateway-CRD-proposal.md

* Update API-Gateway-CRD-proposal.md

* Update API-Gateway-CRD-proposal.md

* Update CRD and scenarios

* Update API-Gateway-CRD-proposal.md

* Update API-Gateway-CRD-proposal.md

* Update API-Gateway-CRD-proposal.md

* Update API-Gateway-CRD-proposal.md

* Update docs/API-Gateway-CRD-proposal.md

Co-authored-by: Tim Riffer <tim.riffer@gmx.de>

* Update API-Gateway-CRD-proposal.md

* Apply suggestions from code review

Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>

* Rename docs/API-Gateway-CRD-proposal.md to docs/contributor/API-Gateway-CRD-proposal.md

* Rename API-Gateway-CRD-proposal.md to 01-10-API-Gateway-CRD-proposal.md

---------

Co-authored-by: Tim Riffer <tim.riffer@gmx.de>
Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>
* two grep invocations less

* workflow file moved

* reverting api rules
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ject#522)

Bumps the k8s-dependencies group with 3 updates: [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery), [k8s.io/client-go](https://github.com/kubernetes/client-go) and [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver).


Updates `k8s.io/apimachinery` from 0.28.1 to 0.28.2
- [Commits](kubernetes/apimachinery@v0.28.1...v0.28.2)

Updates `k8s.io/client-go` from 0.28.1 to 0.28.2
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.28.1...v0.28.2)

Updates `k8s.io/apiextensions-apiserver` from 0.28.1 to 0.28.2
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](kubernetes/apiextensions-apiserver@v0.28.1...v0.28.2)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* initial workflow and scripts

* job names adjusted
* Discover default domain from gateway

* Fallback host to ""

* Add tests and rbac

* Remove unused

* Revert crd

* Review fixes

* Update docu

* Add envtest

* Add envtest

* Use istio handler

* Fix go mod

* Description

* Description

* Update docs/contributor/04-10-technical-design.md

Co-authored-by: Tim Riffer <tim.riffer@gmx.de>

* Update docs/contributor/04-10-technical-design.md

Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>

* Update docs/contributor/04-10-technical-design.md

Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>

---------

Co-authored-by: Tim Riffer <tim.riffer@gmx.de>
Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>
* API Gateway upgrade test (kyma-project#494)

* Istio upgrade test code

* Github workflow

* Wait for job to suceed

* Fix issues

* Update action.yaml

* Update config.go

* Lint

* Not required

* Get TEST_UPGRADE_IMG seperately

* Update tests/integration/testsuites/upgrade/features/upgrade.feature

Co-authored-by: Tim Riffer <tim.riffer@gmx.de>

* Update tests/integration/testsuites/upgrade/features/upgrade.feature

Co-authored-by: Tim Riffer <tim.riffer@gmx.de>

* Update Makefile

Co-authored-by: Tim Riffer <tim.riffer@gmx.de>

* Wait for reconciliation

* Fix retries

* Remove the second namespace, because it is not used in the test.

---------

Co-authored-by: Tim Riffer <tim.riffer@gmx.de>
Co-authored-by: Tim Riffer <tim.riffer@sap.com>

* Fix integration test workflow (kyma-project#508)

* Update main.go

* Update action.yaml

* Fix lint issues

* Update integration-tests.yaml

* Update integration-tests.yaml

* Update main.go

* Update integration-tests.yaml

* Update main.go

* Update integration-tests.yaml

* Update integration-tests.yaml

* Update integration-tests.yaml

* Update action.yaml

* Update integration-tests.yaml

* Update integration-tests.yaml

* Update integration-tests.yaml

* Update integration-tests.yaml

* Update action.yaml

* Update integration-tests.yaml

* Update action.yaml

* Update integration-tests.yaml

* Update integration-tests.yaml

* Update integration-tests.yaml

* Update integration-tests.yaml

* Update main.go

* Update integration-tests.yaml

* Update main.go

* Revert "Merge pull request kyma-project#26 from barchw/barchw-patch-11"

This reverts commit 5ecf518, reversing
changes made to 81ebf6d.

* Update integration-tests.yaml

* Update integration-tests.yaml

* Use environments

* Branch

* Use env

* Use env

* Use env

* Switch boolean

* Switch boolean

* Switch boolean

* Update integration-tests.yaml

* Create 04-30-ci-cd.md

* Apply suggestions from code review

Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>

---------

Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>

* Fix integration test pipeline kyma-project#2 (kyma-project#531)

* Update integration-tests.yaml

* Update action.yaml

* Update action.yaml

* Update integration-tests.yaml

* Update integration-tests.yaml

* Update integration-tests.yaml

* Update integration-tests.yaml

* Update integration-tests.yaml

* Update integration-tests.yaml

* Update action.yaml

* Fix oauth2 scenarios in ory jwt (kyma-project#536)

* Fix oauth2 scenarios in ory jwt

* Remove hydra mentions

* Fix

* Fix apirule import path

---------

Co-authored-by: Bartosz Chwila <103247439+barchw@users.noreply.github.com>
Co-authored-by: Tim Riffer <tim.riffer@gmx.de>
Co-authored-by: Tim Riffer <tim.riffer@sap.com>
Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>
…ma-project#546)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.12.0 to 2.12.1.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.12.0...v2.12.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ect#548)

* layout changes

* more layout changes

* additional message

* silent curl

* do not show progress meter
* add initial api gateway docu

* update documentation

* review docs

* fix links

* revert unnecessary changes

* fix links

* add apirule readme

* language fixes

* review docs

* adjust diagrams

* Remove ClusterRoles

* apply Bartek's suggestions

* remove outdated tutorial

* remove serverless dep

* remove serverless deps

* remove serverless deps

* remove titles

* remove block list tg

* Update docs/user/technical-reference/05-00-api-gateway-operator-parameters.md

Co-authored-by: Bartosz Chwila <103247439+barchw@users.noreply.github.com>

* delete blocklist docu

* fix links

* remove-cipher-suites

* remove articles

* remove minProtocolVersions and cipherSuites from examples

* Apply suggestions from code review

Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>

* Apply suggestions from code review

Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>

* restructure 404 tutorial

* language fixes

* language fixes

* update-links

---------

Co-authored-by: Bartosz Chwila <103247439+barchw@users.noreply.github.com>
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
* Adjust custom domain test's deploy to gardener

* Improve comment
…-project#571)

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.27.10 to 1.28.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.27.10...v1.28.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Save point

* Save point 2

* change deploy script controller to manager

* save point again

* Cleanup

* Remove unused var in tests

* change workflow trigger

* debug

* debug

* debug

* fix dir typo

* quick fix

* kubeconfig changes

* fix input

* Check

* check export

* revert kubeconfig

* Update makefile and change action input

* Fix make target in workflow, remove api gateway from api gateway prereq

* Improvements

* Refactor

* Fix typo

* fix

* fix

* finally

* fix

* fix

* typo

* Refactor

* test

* revert after test

* change target for test

* Set proper trigger
* Add EnableKymaGateway in Gateway CR
Add creation of Kyma Gateway

* Add status handling and Kyma Gateway reconcile

* Fix envtest integration tests

* Add disabling of Kyma Gateway

* Block Kyma gateway deletion if any APIRule exists

* Blocked Kyma Gateway deletion sets APIGateway CR to warning status

* Add DNSEntry reconciliation

* Add DNSEntry CRD

* Add basic certificate creation

* Add Gardener Cert to install

* Reduce code duplication

* Add Gardener certificate reconciliation

* Add default certificate secret

* Add handling for DNS-based load balancer

* Add finalizer

* Update file structure and names

* Simplify finalizer code

* Update local dev certs

* Fix DNSEntries RBAC

* Fix missing kinds in controller client

* Init gateway test

* Fix integration test step

* Add godog tags

* Add kyma gateway resources diagrams

* Add Kyma Gateway docs

* Update Gateway docs

* Revert "Add godog tags"

This reverts commit f0dbfbb.

* Revert "Fix integration test step"

This reverts commit 1913e3d.

* Revert "Init gateway test"

This reverts commit c2c085b.

* Apply documentation suggestions from code review

Co-authored-by: Bartosz Chwila <103247439+barchw@users.noreply.github.com>
Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>

* Update diagrams with diagrams proposed in review

* Code review remarks

* Merge temporary doc into real doc

* Update certificate_secret.yaml

* Update certificate_secret.yaml

---------

Co-authored-by: Patryk Strugacz <patryk.strugacz@sap.com>
Co-authored-by: Bartosz Chwila <103247439+barchw@users.noreply.github.com>
Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>
Co-authored-by: Marek Kołodziejczak <69915024+kolodziejczak@users.noreply.github.com>
…ect#584)

* checkouting PR code for pull requests

* Update .github/actions/integration-tests/action.yaml

Co-authored-by: Bartosz Chwila <103247439+barchw@users.noreply.github.com>

---------

Co-authored-by: Bartosz Chwila <103247439+barchw@users.noreply.github.com>
@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner October 4, 2023 11:10
@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner October 4, 2023 11:10
@kyma-bot kyma-bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 4, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 4, 2023

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot added the area/api-gateway Issues or PRs related to api-gateway label Oct 4, 2023
@kyma-bot kyma-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 4, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 4, 2023

@jaroslaw-pieszka: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-api-gateway-lint b08cbf0 link false /test pull-api-gateway-lint
pull-api-gateway-integration-aws b08cbf0 link true /test pull-api-gateway-integration-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api-gateway Issues or PRs related to api-gateway do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants