Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: backend requests in safari & allow more characters in url #3414

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: backend requests in safari & allow more characters in url #3414

wants to merge 6 commits into from
+5 −17

Conversation

chriskari
Copy link
Contributor

@chriskari chriskari commented Oct 16, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • remove linebreak character at end of url paths in safari

Related issue(s)
#3372

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2024
This was linked to issues Oct 16, 2024
Tighten input validation for requests initiated by the backend #3372
Open
Cannot open resource details on Safari #3411
Open
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2024
@chriskari chriskari changed the title fix: remove linebreak character at end of url paths in safari fix: backend requests in safari & allow more characters in url Oct 16, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2024
mrCherry97
mrCherry97 requested changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@mrCherry97 mrCherry97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test also with # in the resource name, and bring back this https://github.com/kyma-project/busola/pull/3418/files#diff-06bc8a2dfe8c9a223c5b8519b7c26be1ab7c8e3b5b5c02ec8d50f5f841bdb412L6

dbadura
dbadura previously approved these changes Oct 18, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 18, 2024
@dbadura dbadura dismissed their stale review October 18, 2024 12:22

I need to check it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrCherry97 mrCherry97 mrCherry97 requested changes

@dbadura dbadura dbadura left review comments

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@dbadura dbadura

@mrCherry97 mrCherry97

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot open resource details on Safari Tighten input validation for requests initiated by the backend
4 participants
@chriskari @dbadura @mrCherry97 @kyma-bot