Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(AzureRedis): add missing spn permissions #735

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

docs(AzureRedis): add missing spn permissions #735

wants to merge 5 commits into from

Conversation

ijovovic
Copy link
Contributor

Changes proposed in this pull request:

Added following missing SPN permissions to docs:

  • Microsoft.Network/networkSecurityGroups/join/action
  • Microsoft.Network/virtualNetworks/subnets/join/action
  • Microsoft.Network/virtualNetworks/join/action
  • Microsoft.Cache/Redis/PrivateEndpointConnectionsApproval/action
  • Microsoft.Network/privateDnsZones/join/action

@ijovovic ijovovic requested review from a team as code owners October 17, 2024 13:00
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2024
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2024
@ijovovic ijovovic mentioned this pull request Oct 18, 2024
Closed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vandjelk vandjelk vandjelk left review comments

@dushanpantic dushanpantic dushanpantic approved these changes

@grego952 grego952 grego952 approved these changes

Assignees

@dushanpantic dushanpantic

@grego952 grego952

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ijovovic @vandjelk @dushanpantic @grego952 @kyma-bot