Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include istio-system namespace in the deployment yaml of istio module #997

Open
7 tasks done
pbochynski opened this issue Aug 29, 2024 · 2 comments
Open
7 tasks done
Assignees
Labels
area/service-mesh Issues or PRs related to service-mesh kind/feature Categorizes issue or PR as related to a new feature.

Comments

@pbochynski
Copy link
Contributor

pbochynski commented Aug 29, 2024

Description

Add istio-system to the deployment YAML file (one of release artifacts) in order to have it created and managed by the Kyma Lifecycle Manager.

Reasons
We need consistent labeling of system resources for all Kyma modules. See: kyma-project/community#922

DoD:

  • Provide unit and integration tests.
  • Provide documentation.
  • Verify if the solution works for both open-source Kyma and SAP BTP, Kyma runtime.
  • If you changed the resource limits, explain why it was needed.
  • If the default configuration of Istio Operator has been changed, you performed a manual upgrade test to verify that the change can be rolled out correctly.
  • Verify that your contributions don't decrease code coverage. If they do, explain why this is the case.
  • Add release notes.

Attachments

@pbochynski pbochynski added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 29, 2024
@strekm strekm added the area/service-mesh Issues or PRs related to service-mesh label Sep 5, 2024
@strekm
Copy link
Collaborator

strekm commented Oct 10, 2024

We need to check if there will be no conflict between KLM and Istio module.

@videlov
Copy link
Collaborator

videlov commented Oct 16, 2024

We need to check if there will be no conflict between KLM and Istio module.

tested both scenarios without any issues, having new module manifest which includes istio-system namespace definition:

  • creating a new SKR
  • upgrading old SKR

module CR on kcp in both cases in Ready state. Double checked few error messages from KLM operator with @ruanxin. All should be good. No issues.

for the tests, I did create a Istio module dev release for it, version 1.9.1

@videlov videlov removed their assignment Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/service-mesh Issues or PRs related to service-mesh kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants