Add istio-system namespace to module manifest
#1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
do-not-merge/work-in-progress
videlov
changed the title
istio-system namespace to module manifest
kyma-bot
removed
the
do-not-merge/work-in-progress
kyma-bot
added
size/S
|
For the review, unfortunately additional namespace can not be applied with |
werdes72
reviewed
Oct 17, 2024
| @@ -1,2 +1,3 @@ | |||
| ## New Features | |||
| - Remove Istio version `v1alpha1` from the CRD [#1062](https://github.com/kyma-project/istio/pull/1062) | |||
| - We create `istio-system` namespace as part of Module manifest[#1076](https://github.com/kyma-project/istio/pull/1076) following decision for [namespace labeling](https://github.com/kyma-project/community/issues/922) | |||
There was a problem hiding this comment.
Suggested change
| - We create `istio-system` namespace as part of Module manifest[#1076](https://github.com/kyma-project/istio/pull/1076) following decision for [namespace labeling](https://github.com/kyma-project/community/issues/922) | |
| - We create `istio-system` namespace as part of Module manifest [#1076](https://github.com/kyma-project/istio/pull/1076) following decision for [namespace labeling](https://github.com/kyma-project/community/issues/922) |
| @@ -1,2 +1,3 @@ | |||
| ## New Features | |||
| - Remove Istio version `v1alpha1` from the CRD [#1062](https://github.com/kyma-project/istio/pull/1062) | |||
| - We create `istio-system` namespace as part of Module manifest[#1076](https://github.com/kyma-project/istio/pull/1076) following decision for [namespace labeling](https://github.com/kyma-project/community/issues/922) | |||
There was a problem hiding this comment.
Suggested change
| - We create `istio-system` namespace as part of Module manifest[#1076](https://github.com/kyma-project/istio/pull/1076) following decision for [namespace labeling](https://github.com/kyma-project/community/issues/922) | |
| - Now, the `istio-system` namespace is created as part of the module's manifest ([#1076](https://github.com/kyma-project/istio/pull/1076)). See the following [decision for namespace labeling](https://github.com/kyma-project/community/issues/922). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
istio-systemnamespace to module manifestPre-Merge Checklist
Related issues
#997