Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: finalizer model call #225

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: finalizer model call #225

wants to merge 1 commit into from

Conversation

grischperl
Copy link
Collaborator

@grischperl grischperl commented Oct 18, 2024 •
edited
Loading

Description

There was no final response returned as the llm call of the Finalizer was broken. The self.models is a dictionary. A specific model needs to be chosen to access llm.

Changes proposed in this pull request:

  • use the gpt4.o-mini model in the Finalizer

Related issue(s)

@grischperl grischperl requested a review from a team as a code owner October 18, 2024 10:33
@grischperl grischperl added the evaluation requested A PR with this label will trigger the validation workflow. label Oct 18, 2024
@github-actions GitHub Actions
Copy link

The evaluation test will be skipped for this PR. You can trigger it manually by adding the label evaluation requested.

@grischperl grischperl added evaluation requested A PR with this label will trigger the validation workflow. run-integration-test and removed evaluation requested A PR with this label will trigger the validation workflow. labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcobebway marcobebway Awaiting requested review from marcobebway marcobebway is a code owner automatically assigned from kyma-project/ai-force

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla: yes evaluation requested A PR with this label will trigger the validation workflow. run-integration-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grischperl @kyma-bot