forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[lld-macho] Fix for objc_msgSend stubs (llvm#78557)
This commit corrects the address computation for objc_msgSend stubs. Previously, the address computation was incidentally correct due to objc_msgSend often being the first entry in the got section, resulting in a 0 index. This commit ensures accurate address computation regardless of the objc_msgSend stub's position in the got section.
- Loading branch information
1 parent
45d1cca
commit 5de1d00
Showing
2 changed files
with
37 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
# REQUIRES: aarch64 | ||
|
||
# RUN: llvm-mc -filetype=obj -triple=arm64-apple-darwin %s -o %t.o | ||
# RUN: %lld -arch arm64 -lSystem -fixup_chains -o %t.out %t.o | ||
# RUN: llvm-otool -vs __TEXT __objc_stubs %t.out | FileCheck %s --check-prefix=CHECK --check-prefix=FIRST | ||
|
||
# Prepend a dummy entry to check if the address for _objc_msgSend is valid. | ||
# RUN: %lld -arch arm64 -lSystem -fixup_chains -e _dummy -U _dummy -o %t.out %t.o | ||
# RUN: llvm-otool -vs __TEXT __objc_stubs %t.out | FileCheck %s --check-prefix=CHECK --check-prefix=SECOND | ||
|
||
# CHECK: Contents of (__TEXT,__objc_stubs) section | ||
|
||
# CHECK-NEXT: _objc_msgSend$foo: | ||
# CHECK-NEXT: adrp x1, 8 ; 0x100008000 | ||
# CHECK-NEXT: ldr x1, [x1] | ||
# CHECK-NEXT: adrp x16, 4 ; 0x100004000 | ||
# FIRST-NEXT: ldr x16, [x16] | ||
# SECOND-NEXT:ldr x16, [x16, #0x8] | ||
# CHECK-NEXT: br x16 | ||
# CHECK-NEXT: brk #0x1 | ||
# CHECK-NEXT: brk #0x1 | ||
# CHECK-NEXT: brk #0x1 | ||
|
||
# CHECK-EMPTY: | ||
|
||
.text | ||
.globl _objc_msgSend | ||
_objc_msgSend: | ||
ret | ||
|
||
.globl _main | ||
_main: | ||
bl _objc_msgSend$foo | ||
ret |