Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for alternative report storage (aggregation API / extension API server) #51

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stone-z
Copy link

@stone-z stone-z commented Nov 3, 2023

Opening in parallel with #50 to avoid a massive PR review, but please take whichever is preferable for the maintainers.

Much of this is now very nicely captured by @vishal-chdhry's PR, this draft is just to capture the background we've done at Giant Swarm so the maintainers can consider and incorporate any notable differences. I had wanted to open this sooner, but other priorities and my inability to publish something until it is "perfect" got in the way 😅 thanks for your patience.

The most notable additions / differences between this and the current state of the other PR, as I see it, are:

  • my proposal includes storing other types beyond PolicyReports. There are more types which suffer the same issue -- this component can solve the issue for them as well.
  • in my mind, this subsystem makes the most sense if report types are considered ephemeral. If reports are understood to be regenerated if deleted, migration is a nice to have but not strictly necessary, and guarantees about the RDBMS can be more relaxed. Preserving historical data has been a stated non-goal of this database -- it is only intended to reflect the "current" cluster state. Reports should be shipped to external storage for long-term archival.

Signed-off-by: Zach Stone <zach@giantswarm.io>
Signed-off-by: Zach Stone <zach@giantswarm.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants