proposal: Add mutation support for the kyverno CLI #62
Conversation
Signed-off-by: aerosouund <aerosound161@gmail.com>
aerosouund
force-pushed
the
mutate-cli-support
branch
2 times, most recently
from
949ffa6
to
53d64b3
Compare
proposals/mutation-support-cli.md
Outdated
| request.operation: UPDATE | ||
| ``` | ||
|
|
||
| The `targetResources` key will be added, with an array of objects containing two keys: name (a string) and values (a `map[string]interface{}`). |
There was a problem hiding this comment.
You need an unique identifier for the target resource. Having the name only could cause the confusion if two resources are with the same name but different namespaces.
There was a problem hiding this comment.
This is how currently resources are being identified for policy variables as well.
We can improve this by adding a namespace variable to this schema. This will apply to target resource variables and policy variables
There was a problem hiding this comment.
The current solution needs to be improved. Though this is not a major use case, duplicate resource names could be provided to the CLI.
There was a problem hiding this comment.
Yeah, which is why i was kinda reluctant to consider this case. because it's already a pretty niche case and i didn't know if the complexity of the change will equal the value gained from addressing it.
I will include it and we can change it back later
Signed-off-by: aerosouund <aerosound161@gmail.com>
aerosouund
force-pushed
the
mutate-cli-support
branch
from
213239b
to
b960437
Compare
Proposal document that addresses kyverno/kyverno#4354