chore: remove useless config validation (#1642)

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

pkg/loaders/config/load.go

@@ -16,7 +16,6 @@ import (
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/runtime/schema"
-	"k8s.io/apimachinery/pkg/util/validation/field"
 	"k8s.io/client-go/openapi"
 	"sigs.k8s.io/kubectl-validate/pkg/openapiclient"
 )
@@ -29,7 +28,6 @@ type (
 	splitter      = func([]byte) ([][]byte, error)
 	loaderFactory = func(openapi.Client) (loader.Loader, error)
 	converter     = func(schema.GroupVersionKind, unstructured.Unstructured) (*v1alpha2.Configuration, error)
-	validator     = func(obj *v1alpha2.Configuration) field.ErrorList
 )
 
 var (
@@ -64,10 +62,10 @@ func LoadBytes(content []byte) (*v1alpha2.Configuration, error) {
 }
 
 func Parse(content []byte) ([]*v1alpha2.Configuration, error) {
-	return parse(content, nil, nil, nil, nil)
+	return parse(content, nil, nil, nil)
 }
 
-func parse(content []byte, splitter splitter, loaderFactory loaderFactory, converter converter, validator validator) ([]*v1alpha2.Configuration, error) {
+func parse(content []byte, splitter splitter, loaderFactory loaderFactory, converter converter) ([]*v1alpha2.Configuration, error) {
 	if splitter == nil {
 		splitter = yaml.SplitDocuments
 	}
@@ -77,12 +75,6 @@ func parse(content []byte, splitter splitter, loaderFactory loaderFactory, conve
 	if converter == nil {
 		converter = defaultConverter
 	}
-	if validator == nil {
-		// TODO: replace with schema validation
-		validator = func(obj *v1alpha2.Configuration) field.ErrorList {
-			return nil
-		}
-	}
 	documents, err := splitter(content)
 	if err != nil {
 		return nil, err
@@ -106,9 +98,6 @@ func parse(content []byte, splitter splitter, loaderFactory loaderFactory, conve
 		if err != nil {
 			return nil, err
 		}
-		if err := validator(config).ToAggregate(); err != nil {
-			return nil, err
-		}
 		configs = append(configs, config)
 	}
 	return configs, nil

pkg/loaders/config/load_test.go

@@ -14,7 +14,6 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/runtime/schema"
-	"k8s.io/apimachinery/pkg/util/validation/field"
 	"k8s.io/client-go/openapi"
 	"k8s.io/utils/ptr"
 )
@@ -141,7 +140,6 @@ func Test_parse(t *testing.T) {
 		splitter      splitter
 		loaderFactory loaderFactory
 		converter     converter
-		validator     validator
 		wantErr       bool
 	}{{
 		name:          "default",
@@ -185,21 +183,10 @@ func Test_parse(t *testing.T) {
 			return nil, errors.New("converter")
 		},
 		wantErr: true,
-	}, {
-		name:          "validator error",
-		splitter:      nil,
-		loaderFactory: nil,
-		converter:     nil,
-		validator: func(obj *v1alpha2.Configuration) field.ErrorList {
-			return field.ErrorList{
-				field.Invalid(nil, nil, ""),
-			}
-		},
-		wantErr: true,
 	}}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			_, err := parse(content, tt.splitter, tt.loaderFactory, tt.converter, tt.validator)
+			_, err := parse(content, tt.splitter, tt.loaderFactory, tt.converter)
 			if tt.wantErr {
 				assert.Error(t, err)
 			} else {