Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test level bindings evaluated too early #1097

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

eddycharly
Copy link
Member

@eddycharly eddycharly commented Mar 12, 2024

Explanation

Fix test level bindings evaluated too early.

See linode/cluster-api-provider-linode#181

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 71.03%. Comparing base (c6560f4) to head (8e8ea3d).

❗ Current head 8e8ea3d differs from pull request most recent head de00354. Consider uploading reports for the commit de00354 to get more accurate results

Files Patch % Lines
pkg/runner/processors/test.go 40.00% 2 Missing and 1 partial ⚠️
pkg/runner/processors/tests.go 40.00% 2 Missing and 1 partial ⚠️
pkg/runner/processors/operation.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1097      +/-   ##
==========================================
+ Coverage   71.01%   71.03%   +0.02%     
==========================================
  Files         132      132              
  Lines        4633     4637       +4     
==========================================
+ Hits         3290     3294       +4     
  Misses       1082     1082              
  Partials      261      261              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly merged commit 726ca61 into kyverno:main Mar 12, 2024
11 of 12 checks passed
@eddycharly eddycharly deleted the fix-high-level-bindings branch March 12, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant