Allow escaping dollar sign in command and script #2130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
I want to pass a literal containing
$$
to mycommand
operation as an argument. Unfortunately, Chainsaw removes this value when/before invoking the command.Related issue
Proposed Changes
This treats pairs of dollar signs as an escape representing one dollar sign. This matches Kubernetes' behavior for container command and args fields.
Checklist
Further Comments
The behavior of os.Expand is undefined and inconsistent for runs of dollar signs U+0024. Without this change, the proposed test fails: