Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve the PR semantics #787

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Conversation

shubham-cmyk
Copy link
Member

@shubham-cmyk shubham-cmyk commented Feb 1, 2024

Explanation

Improve the PR semantics to make the PR more presentable.
reference : https://github.com/commitizen/conventional-commit-types

 Example:
 test(runner): Add test for the runner
 ^    ^        ^
 |    |        |__ Subject
 |    |_______ Scope
 |____________ Type

Related issue

#790

Proposed Changes

Adding a CI to improve the PR semantics

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (57cec70) 79.55% compared to head (1c10178) 79.55%.

❗ Current head 1c10178 differs from pull request most recent head 21dafc2. Consider uploading reports for the commit 21dafc2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #787   +/-   ##
=======================================
  Coverage   79.55%   79.55%           
=======================================
  Files         104      104           
  Lines        3174     3174           
=======================================
  Hits         2525     2525           
  Misses        505      505           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
@shubham-cmyk shubham-cmyk marked this pull request as ready for review February 2, 2024 18:03
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
@eddycharly eddycharly enabled auto-merge (squash) February 2, 2024 19:05
@eddycharly eddycharly merged commit c2766d9 into kyverno:main Feb 2, 2024
7 of 8 checks passed
@shubham-cmyk shubham-cmyk deleted the pr-title-checker branch February 6, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants