Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report): report path and prevent double extension on file name #951

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

shubham-cmyk
Copy link
Member

@shubham-cmyk shubham-cmyk commented Feb 21, 2024

Signed-off-by: Shubham Gupta iamshubhamgupta2001@gmail.com

Explanation

don't put double extension on a filename

Related issue

Fixes #930

Proposed Changes

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.

Further Comments

@shubham-cmyk shubham-cmyk requested a review from a team as a code owner February 21, 2024 15:48
pkg/report/report.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d15316c) 74.75% compared to head (3d99bbe) 74.76%.

❗ Current head 3d99bbe differs from pull request most recent head 49e8fd4. Consider uploading reports for the commit 49e8fd4 to get more accurate results

Files Patch % Lines
pkg/report/report.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #951   +/-   ##
=======================================
  Coverage   74.75%   74.76%           
=======================================
  Files         114      114           
  Lines        3799     3800    +1     
=======================================
+ Hits         2840     2841    +1     
  Misses        767      767           
  Partials      192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shubham-cmyk shubham-cmyk enabled auto-merge (squash) February 21, 2024 16:22
@shubham-cmyk shubham-cmyk changed the title feat: check file extension fix: report path and prevent double extension on file name Feb 21, 2024
@shubham-cmyk shubham-cmyk changed the title fix: report path and prevent double extension on file name fix(report): report path and prevent double extension on file name Feb 21, 2024
eddycharly
eddycharly previously approved these changes Feb 21, 2024
Copy link
Member

@eddycharly eddycharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eddycharly
Copy link
Member

@shubham-cmyk can you add a line in the release notes ?

@shubham-cmyk
Copy link
Member Author

yes

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
@shubham-cmyk shubham-cmyk merged commit c32f7d6 into kyverno:main Feb 21, 2024
10 checks passed
@shubham-cmyk shubham-cmyk deleted the report-name branch February 22, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add --report-path to save the test report in a specified path.
2 participants