Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(operations): error and assert condition #958

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

shubham-cmyk
Copy link
Member

@shubham-cmyk shubham-cmyk commented Feb 22, 2024

Explanation

According to demorgan law.

( A` && B` )`  is same as ( A || B ). 

Maybe we can improve this condition over here and simply it.

Proposed Changes

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.

Further Comments

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
@shubham-cmyk shubham-cmyk requested a review from a team as a code owner February 22, 2024 18:39
@shubham-cmyk shubham-cmyk changed the title refactor(operation): refactor error and assert condition refactor(operation): error and assert condition Feb 22, 2024
@shubham-cmyk shubham-cmyk changed the title refactor(operation): error and assert condition refactor(operation): refactor error and assert condition Feb 22, 2024
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
@shubham-cmyk shubham-cmyk changed the title refactor(operation): refactor error and assert condition refactor(operations): error and assert condition Feb 22, 2024
@shubham-cmyk shubham-cmyk enabled auto-merge (squash) February 22, 2024 18:45
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.81%. Comparing base (274bbce) to head (82767d1).

❗ Current head 82767d1 differs from pull request most recent head cb226c8. Consider uploading reports for the commit cb226c8 to get more accurate results

Files Patch % Lines
pkg/runner/operations/assert/operation.go 0.00% 0 Missing and 1 partial ⚠️
pkg/runner/operations/error/operation.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #958      +/-   ##
==========================================
+ Coverage   74.05%   74.81%   +0.75%     
==========================================
  Files         115      114       -1     
  Lines        3878     3800      -78     
==========================================
- Hits         2872     2843      -29     
+ Misses        809      766      -43     
+ Partials      197      191       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shubham-cmyk shubham-cmyk merged commit 1fd0ae4 into kyverno:main Feb 23, 2024
10 checks passed
@eddycharly eddycharly added this to the v0.1.7 milestone Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants