Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add env vars support in command and script #963

Merged
merged 2 commits into from
Feb 24, 2024
Merged

feat: add env vars support in command and script #963

merged 2 commits into from
Feb 24, 2024

Conversation

eddycharly
Copy link
Member

Explanation

Add env vars support in command and script.

Related issue

Fixes #953

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 29.41176% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 73.56%. Comparing base (1fd0ae4) to head (6f229d6).

Files Patch % Lines
pkg/runner/operations/internal/env.go 0.00% 17 Missing ⚠️
pkg/apis/v1alpha1/binding.go 0.00% 14 Missing ⚠️
pkg/runner/operations/command/operation.go 80.00% 1 Missing and 1 partial ⚠️
pkg/runner/operations/script/operation.go 77.77% 1 Missing and 1 partial ⚠️
pkg/runner/processors/bindings.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #963      +/-   ##
==========================================
- Coverage   74.05%   73.56%   -0.50%     
==========================================
  Files         115      117       +2     
  Lines        3878     3907      +29     
==========================================
+ Hits         2872     2874       +2     
- Misses        809      834      +25     
- Partials      197      199       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eddycharly eddycharly marked this pull request as ready for review February 24, 2024 09:14
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly merged commit 8cbf418 into main Feb 24, 2024
12 of 14 checks passed
@eddycharly eddycharly deleted the env-vars branch February 24, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add custom env vars support to command and script operations
1 participant