Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change escaping char #87

Merged
merged 2 commits into from
Oct 10, 2023
Merged

fix: change escaping char #87

merged 2 commits into from
Oct 10, 2023

Conversation

eddycharly
Copy link
Member

Explanation

Change escaping char

Related issue

Fixes #81

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Copy link
Member

@JimBugwadia JimBugwadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Had a question on the trailing \...

@@ -344,17 +344,17 @@ spec:
assert:
all:
- foo:
/(bar)/: 10
\(bar)\: 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the trailing \ necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, to escape the binding

@eddycharly eddycharly merged commit 88cbfdf into main Oct 10, 2023
5 checks passed
@eddycharly eddycharly deleted the escape branch October 10, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Change the escape operator to backslash
2 participants