best-practices+karpenter+other: Enhance policies by iterating over all container types #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamedawnallah
force-pushed
the
iterateAllContainerTypes
branch
from
cebc629
to
bba39a3
Compare
chipzoller
suggested changes
Jul 14, 2024
chipzoller
suggested changes
Jul 14, 2024
other/memory-requests-equal-limits/memory-requests-equal-limits.yaml
Outdated
Show resolved
Hide resolved
mohamedawnallah
force-pushed
the
iterateAllContainerTypes
branch
5 times, most recently
from
e5e9bd5
to
472666c
Compare
In this commit, we ensure policies apply to `ephemeralContainers`, `initContainers`, and `containers`. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
In this commit, we compute sha256 of the changed policies using `sha256sum` utility for integrity. Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
mohamedawnallah
force-pushed
the
iterateAllContainerTypes
branch
from
472666c
to
428be01
Compare
|
Thanks a lot @chipzoller for the feedback! I've addressed all of it. The test cases all passed as you seen in my fork repo: |
|
FYI, after addressing comments, please resolve conversations so maintainers know what to expect on subsequent reviews. |
chipzoller
suggested changes
Aug 2, 2024
There was a problem hiding this comment.
This policy is not correctly updated to account for the addition of initContainers and ephemeralContainers. The context variable is still operating on just containers which is causing CI tests to fail.
There was a problem hiding this comment.
@mohamedawnallah - can you please resolve this, so we can merge?
|
Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Closes #1012
Description
Enhance policies by iterating over all container types i.e
ephemeralContainers,initContainers, andcontainers.Context
This is my first PR to Kyverno Org! I would love to receive any feedback, thanks! 🙏
Checklist