-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Disallow hostPorts in CEL expressions #1101
Conversation
Signed-off-by: Lavish pal <lvishpal408@gmail.com>
cc: @JimBugwadia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the contribution guide here, specifically the part about modifying Artifact Hub metadata.
@chipzoller I read the contribution guide lines and about Artifact Hub. |
Yes, you need to recalculate the digest of the policy and update the relevant section in the AH metadata file. |
Tests failing. |
Can there be different digest values for same policy? |
If you generate the digest on WIndows versus Linux, yes. The difference in digests come from control characters and line endings. The digests should be generated under Linux or else CI will fail. |
Still getting the different digest value from the value given in artifacthub-pkg.yaml of the file |
Thank you @chipzoller for the guidance, now I will quickly update the artifacthub file. |
Signed-off-by: Lavish pal <lvishpal408@gmail.com>
65ac8eb
to
504f84c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLI tests now failing after modifications in this policy.
Signed-off-by: Lavish pal <lavish@debian.0.2.15>
091d84e
to
1cc36de
Compare
Closed this pr in favor of #1108 |
Related Issue(s)
fixes #1093
Description
This PR simplify the CEL expression by removing the repeated terms.
Checklist