Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Restrict sysctls in CEL expressions #1106

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lavishpal
Copy link

Related Issue(s)

Fixes #1100

Description

This PR simplify the CEL expression by removing the repeated terms.

Checklist

  • [] I have read the policy contribution guidelines.
  • [] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
  • [] I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

@lavishpal lavishpal force-pushed the simplify-cel-sysctls-policy branch 2 times, most recently from 8f1746c to 5250f05 Compare August 2, 2024 06:51
@lavishpal
Copy link
Author

cc: @chipzoller

@chipzoller
Copy link
Contributor

chipzoller commented Aug 2, 2024

Please review the contribution guide as I pointed out in this comment.

Copy link
Contributor

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No updated Artifact Hub metadata file present.

@lavishpal
Copy link
Author

Update the Artifact hub.

@chipzoller chipzoller changed the title Enhanced:Simplify the Cel Expression of restrict sysctls Simplify Restrict sysctls in CEL expressions Aug 2, 2024
@chipzoller
Copy link
Contributor

Please also remember to complete the items defined in the PR template's checklist in future PRs.

Copy link
Contributor

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI tests for this modified policy now failing.

Signed-off-by: Lavish pal <lvishpal408@gmail.com>
Signed-off-by: Lavish pal <lvishpal408@gmail.com>
@JimBugwadia
Copy link
Member

@lavishpal - please resolve conflicts, so we can complete reviews and merge. Thanks!

Signed-off-by: Lavish Pal <lvishpal408@gmail.com>
@lavishpal
Copy link
Author

@JimBugwadia Resolved the merge conflict. Thank you

@realshuting realshuting requested review from chipzoller and MariamFahmy98 and removed request for chipzoller August 29, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restrict-sysctls: simplify CEL expressions
4 participants