fix: dont append

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
kyverno · Jul 4, 2024 · 45d5e86 · 45d5e86
1 parent a9b825d
commit 45d5e86
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 32 deletions.
diff --git a/pkg/api/cephr.go b/pkg/api/cephr.go
@@ -287,17 +287,17 @@ func (c *cephrStore) Watch(ctx context.Context, options *metainternalversion.Lis
 		return nil, fmt.Errorf("failed to convert runtime object into cluster ephemeral report list")
 	}
 	events := make([]watch.Event, len(list.Items))
-	for _, p := range list.Items {
-		if p.Generation == 1 || p.Generation == 0 {
-			events = append(events, watch.Event{
+	for i, pol := range list.Items {
+		if pol.Generation == 1 || pol.Generation == 0 {
+			events[i] = watch.Event{
 				Type:   watch.Added,
-				Object: &p,
-			})
+				Object: &pol,
+			}
 		} else {
-			events = append(events, watch.Event{
+			events[i] = watch.Event{
 				Type:   watch.Modified,
-				Object: &p,
-			})
+				Object: &pol,
+			}
 		}
 	}
 	return c.broadcaster.WatchWithPrefix(events)

diff --git a/pkg/api/cpolr.go b/pkg/api/cpolr.go
@@ -286,17 +286,17 @@ func (c *cpolrStore) Watch(ctx context.Context, options *metainternalversion.Lis
 		return nil, fmt.Errorf("failed to convert runtime object into cluster policy report list")
 	}
 	events := make([]watch.Event, len(list.Items))
-	for _, p := range list.Items {
-		if p.Generation == 1 || p.Generation == 0 {
-			events = append(events, watch.Event{
+	for i, pol := range list.Items {
+		if pol.Generation == 1 || pol.Generation == 0 {
+			events[i] = watch.Event{
 				Type:   watch.Added,
-				Object: &p,
-			})
+				Object: &pol,
+			}
 		} else {
-			events = append(events, watch.Event{
+			events[i] = watch.Event{
 				Type:   watch.Modified,
-				Object: &p,
-			})
+				Object: &pol,
+			}
 		}
 	}
 	return c.broadcaster.WatchWithPrefix(events)

diff --git a/pkg/api/ephr.go b/pkg/api/ephr.go
@@ -307,17 +307,17 @@ func (p *ephrStore) Watch(ctx context.Context, options *metainternalversion.List
 		return nil, fmt.Errorf("failed to convert runtime object into ephemeral report list")
 	}
 	events := make([]watch.Event, len(list.Items))
-	for _, p := range list.Items {
-		if p.Generation == 1 || p.Generation == 0 {
-			events = append(events, watch.Event{
+	for i, pol := range list.Items {
+		if pol.Generation == 1 || pol.Generation == 0 {
+			events[i] = watch.Event{
 				Type:   watch.Added,
-				Object: &p,
-			})
+				Object: &pol,
+			}
 		} else {
-			events = append(events, watch.Event{
+			events[i] = watch.Event{
 				Type:   watch.Modified,
-				Object: &p,
-			})
+				Object: &pol,
+			}
 		}
 	}
 	return p.broadcaster.WatchWithPrefix(events)

diff --git a/pkg/api/polr.go b/pkg/api/polr.go
@@ -307,17 +307,17 @@ func (p *polrStore) Watch(ctx context.Context, options *metainternalversion.List
 		return nil, fmt.Errorf("failed to convert runtime object into policy report list")
 	}
 	events := make([]watch.Event, len(list.Items))
-	for _, p := range list.Items {
-		if p.Generation == 1 || p.Generation == 0 {
-			events = append(events, watch.Event{
+	for i, pol := range list.Items {
+		if pol.Generation == 1 || pol.Generation == 0 {
+			events[i] = watch.Event{
 				Type:   watch.Added,
-				Object: &p,
-			})
+				Object: &pol,
+			}
 		} else {
-			events = append(events, watch.Event{
+			events[i] = watch.Event{
 				Type:   watch.Modified,
-				Object: &p,
-			})
+				Object: &pol,
+			}
 		}
 	}
 	return p.broadcaster.WatchWithPrefix(events)