Load PostgreSQL connection configuration from K8s secret #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach Stone <zach@giantswarm.io>
Signed-off-by: Zach Stone <zach@giantswarm.io>
Signed-off-by: Zach Stone <zach@giantswarm.io>
Signed-off-by: Zach Stone <zach@giantswarm.io>
Signed-off-by: Zach Stone <zach@giantswarm.io>
Signed-off-by: Zach Stone <zach@giantswarm.io>
|
thanks @stone-z ! |
Signed-off-by: Zach Stone <zach@giantswarm.io>
|
I think the codecov failure is unrelated (?) since it is being rate limited. Or maybe external PRs don't have the token injected? |
vishal-chdhry
approved these changes
Apr 30, 2024
|
yep that looks unrelated to me |
stone-z
added a commit
to giantswarm/reports-server-upstream
that referenced
this pull request
Jul 4, 2024
* Create sync-from-upstream.yaml Signed-off-by: Zach Stone <zach@giantswarm.io> * Update sync-from-upstream.yaml Signed-off-by: Zach Stone <zach@giantswarm.io> * Allow loading Postgres config from secret Signed-off-by: Zach Stone <zach@giantswarm.io> * Remove GS workflow (#1) Signed-off-by: Zach Stone <zach@giantswarm.io> * Update README Signed-off-by: Zach Stone <zach@giantswarm.io> * Use genreic "DB" instead of PG-specific references Signed-off-by: Zach Stone <zach@giantswarm.io> * Fix codegen-ed README Signed-off-by: Zach Stone <zach@giantswarm.io> --------- Signed-off-by: Zach Stone <zach@giantswarm.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To better support PostgreSQL instances managed outside this chart, it would be helpful if the server could read connection information from a secret in the cluster instead of requiring it to be supplied through Helm values.
This PR modifies the deployment so that values will be used from the named Secret, if one is supplied, and will use the Helm values if no Secret name is given.