Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for embedded etcd #213

Merged
merged 15 commits into from
Oct 31, 2024
Merged

feat: add support for embedded etcd #213

merged 15 commits into from
Oct 31, 2024

Conversation

vishal-chdhry
Copy link
Member

No description provided.

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
JimBugwadia
JimBugwadia previously approved these changes Oct 8, 2024
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 199 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (c0d75ef) to head (1559465).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/storage/etcd/store.go 0.00% 138 Missing ⚠️
pkg/storage/etcd/new.go 0.00% 31 Missing ⚠️
pkg/storage/store.go 0.00% 15 Missing ⚠️
pkg/app/opts/options.go 0.00% 8 Missing ⚠️
pkg/server/config.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main    #213    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files         30      32     +2     
  Lines      17670   18611   +941     
======================================
- Misses     17670   18611   +941     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
@vishal-chdhry vishal-chdhry marked this pull request as ready for review October 31, 2024 09:07
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
@vishal-chdhry vishal-chdhry merged commit 5579039 into main Oct 31, 2024
21 checks passed
@vishal-chdhry vishal-chdhry deleted the embedded-etcd branch October 31, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants