Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChatGPT fine-tuned model option #234

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ldhoax
Copy link

@ldhoax ldhoax commented Mar 17, 2024

image

@mkorpela
Copy link
Collaborator

@ldhoax thanks for the PR.
I think the main point would be to be able to configure the model (specifically model name) used?

Current approach in OpenGPTs is a bit rigid. I hope that will be changed in the future to a configuration that live in the database.

@ldhoax
Copy link
Author

ldhoax commented Mar 17, 2024

I agree that the current approach is a bit rigid 😄 but I think it's a bit inconvenient and difficult to work with just config in the database, for several reasons:

  • With new agents (like google_agent, xml_agent), we still need new code to handle
  • And in my case, I just used one OpenAI key for my fine-tuned model, I think it doesn't really need a database for that key 😄 and also a bit insecure.

I think our expectation is just to add new model name to an existing object (like AgentType) every time a new model becomes available. How do you think @mkorpela 🤔

@ptgoetz ptgoetz added models Adds or updates LLM model support backend Changes to the backend service labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Changes to the backend service models Adds or updates LLM model support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants