[de] add words + gGEC AP + removed currencies #10961
Conversation
WalkthroughThis pull request introduces multiple updates across various files in the German language module of LanguageTool. Key changes include the addition of new terms to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
languagetool-language-modules/de/src/main/resources/org/languagetool/rules/de/de-DE-AT/grammar.xml (1)
690-690: Excellent enhancement of currency detection!The expansion of the currency regex pattern significantly improves the rule's coverage. This change will help catch more cases of incorrect currency formatting, enhancing the overall effectiveness of the grammar checker for German texts.
Consider adding a comment explaining the extensive list of currencies. This would help future maintainers understand the purpose and scope of this comprehensive regex.
languagetool-language-modules/de/src/main/resources/org/languagetool/rules/de/remote-rule-filters.xml (1)
2354-2364: New rule for monetary value detection looks good, but could be enhanced.The new rule for detecting monetary values, particularly for Swiss Francs and Japanese Yen, is a good addition. However, consider the following enhancements:
- Add a
<suggestion>tag to specify the correct format if there's a standard way these amounts should be written.- Consider expanding the rule to cover other currencies if appropriate.
- Add a comment explaining the purpose of the rule for future maintenance.
Here's a suggested enhancement:
<!-- Rule for standardizing monetary values for CHF and JPY --> <rule> <pattern> <marker> <token regexp="yes">[0-9]+\.[0-9]{2}|–</token> </marker> <token regexp="yes">CHF|s?Fr\.?|Franken?|Schweizerfranken?|Schwiizerfranken?|Rappen?|Rp\.?|JPY|Yen|¥</token> </pattern> <suggestion><match no="1"/> <match no="2"/></suggestion> <example>Es kostet <marker>11.90</marker> Franken pro Jahr.</example> <example correction="11.90 CHF">Es kostet <marker>11.90</marker> Franken pro Jahr.</example> </rule>This enhancement includes a suggestion (which keeps the original format but ensures consistency), an additional example with a correction, and a comment explaining the rule's purpose.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (5)
- languagetool-language-modules/de/src/main/resources/org/languagetool/resource/de/hunspell/ignore.txt (1 hunks)
- languagetool-language-modules/de/src/main/resources/org/languagetool/resource/de/multitoken-suggest.txt (1 hunks)
- languagetool-language-modules/de/src/main/resources/org/languagetool/rules/de/de-DE-AT/grammar.xml (1 hunks)
- languagetool-language-modules/de/src/main/resources/org/languagetool/rules/de/remote-rule-filters.xml (1 hunks)
- languagetool-language-modules/de/src/main/resources/org/languagetool/rules/de/replace.txt (1 hunks)
✅ Files skipped from review due to trivial changes (1)
- languagetool-language-modules/de/src/main/resources/org/languagetool/resource/de/hunspell/ignore.txt
🧰 Additional context used
🔇 Additional comments (9)
languagetool-language-modules/de/src/main/resources/org/languagetool/rules/de/replace.txt (6)
814-814: Correct separation and capitalization.The change from "Fettarmekost" to "fettarme Kost" is appropriate. It correctly separates the compound word and adjusts the capitalization, improving readability and adhering to proper German spelling rules.
815-815: Correct separation and capitalization.The change from "Gutelaune" to "gute Laune" is appropriate. It correctly separates the compound word and adjusts the capitalization, improving readability and adhering to proper German spelling rules.
816-816: Correct addition of umlaut.The change from "Lugenbrief" to "Lügenbrief" is correct. It adds the necessary umlaut, aligning the word with proper German spelling.
817-817: Correct addition of umlaut in plural form.The change from "Lugenbriefe" to "Lügenbriefe" is correct. It adds the necessary umlaut to the plural form, maintaining consistency with the singular form and aligning with proper German spelling.
818-818: Correct addition of umlaut in genitive form.The change from "Lugenbriefs" to "Lügenbriefs" is correct. It adds the necessary umlaut to the genitive form, maintaining consistency with other forms and aligning with proper German spelling.
Line range hint
819-820: Correct addition of umlaut in various forms.The changes from "Lugenbriefes" to "Lügenbriefes" and "Lugenbriefen" to "Lügenbriefen" are correct. They add the necessary umlaut to different forms of the word, maintaining consistency across all variations and aligning with proper German spelling.
languagetool-language-modules/de/src/main/resources/org/languagetool/resource/de/multitoken-suggest.txt (3)
3115-3115: LGTM: New entry "Artocarpus heterophyllus" added correctly.The addition of "Artocarpus heterophyllus" is consistent with existing scientific name entries in the file. It's properly formatted without any suffix, which is appropriate for scientific names.
3116-3116: LGTM: New entry "Hua Luogeng/S" added correctly.The addition of "Hua Luogeng/S" is consistent with existing person name entries in the file. The "/S" suffix is correctly applied, likely indicating the plural form.
3115-3116: Summary: Beneficial additions to the multitoken suggestions.The two new entries, "Artocarpus heterophyllus" and "Hua Luogeng/S", are valuable additions to the German language module's multitoken suggestions. They expand the resource's coverage of scientific terms and notable figures, which can improve the language tool's ability to handle diverse text content.
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
These updates aim to enhance the overall performance and accuracy of the German language module in LanguageTool.