Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Added a couple of words to spelling.txt #10985

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

marcoagpinto
Copy link
Member

@marcoagpinto marcoagpinto commented Nov 4, 2024

Words missing for years, and the singular one appears in a document I have been writing. It was about time I added it.

Summary by CodeRabbit

  • New Features
    • Enhanced spelling support with the addition of new questionable foreign words and Portuguese terms for review.
    • Notable new entries include autoevidência and autoevidências.

Copy link
Contributor

coderabbitai bot commented Nov 4, 2024

Walkthrough

The pull request involves modifications to the spelling.txt file in the Portuguese language module of LanguageTool. New questionable foreign words and terms have been added to the list, with a focus on Portuguese vocabulary. The additions, indicated by a + sign, do not alter existing entries, and no deletions have occurred. The changes were made by Marco A.G. Pinto at the request of Pedro, who aims to enhance the dictionary building process.

Changes

File Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/spelling.txt Added new entries for questionable foreign words and terms, including autoevidência and autoevidências.

Possibly related PRs

Suggested reviewers

  • p-goulart
  • susanaboatto

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7bfbc77 and bcb1e8b.

📒 Files selected for processing (1)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/spelling.txt (1 hunks)
🔇 Additional comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/spelling.txt (1)

372-373: LGTM! Verify dictionary inclusion.

The additions of "autoevidência" and "autoevidências" follow the file's conventions and maintain alphabetical order.

Let's verify if these terms are recognized in Portuguese dictionaries:

✅ Verification successful

The terms follow Portuguese compound word formation rules

Based on the analysis of the Portuguese language files in the codebase:

  1. The terms "autoevidência" and "autoevidências" follow the same pattern as other accepted Portuguese compound words with the "auto-" prefix
  2. The codebase shows many examples of similar compound words in Portuguese that don't use hyphens (e.g., "autoajuda", "autoavaliação", "autoestima")
  3. The terms are consistent with the Portuguese spelling reform rules as evidenced by the AOreplace.txt file which shows the trend of removing hyphens from "auto-" compounds
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for existing usage of these terms in the codebase
# and other dictionary files to ensure consistency

# Search for any existing references to these terms
rg -i "autoevidência|autoevidências" 

# Check if these terms exist in other Portuguese dictionary files
fd -e dic -e dict -e txt . | grep -i "pt.*dict" | xargs grep -i "autoevidência"

Length of output: 345


Script:

#!/bin/bash
# Let's try a different approach to verify these terms:

# 1. Check for any compound words starting with "auto" in Portuguese dictionary files
fd . -e txt -e dic -e dict | grep -i "pt" | xargs grep -i "^auto" 2>/dev/null

# 2. Look for spelling/dictionary configuration files that might define compound word rules
fd . -e xml -e conf | grep -i "pt.*spell" | xargs cat 2>/dev/null

# 3. Check if there are any test cases or examples using these terms
rg -i "autoevidência" -g "*.xml" -g "*.txt" -g "*.properties"

# 4. Look for documentation about Portuguese compound words
fd . -e md -e txt | grep -i "readme\|doc" | xargs grep -i "compound.*word" 2>/dev/null

Length of output: 43584


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@marcoagpinto marcoagpinto merged commit a31f917 into master Nov 4, 2024
5 checks passed
@marcoagpinto marcoagpinto deleted the lt_marcoagpinto_20241104_1328 branch November 4, 2024 14:13
@marcoagpinto
Copy link
Member Author

@jaumeortola

I will do the major disambiguator one tonight I hope, ChatGPT wasn't allowing me to check the nouns/verbs (maybe peak time, as it said to try later or move to the Plus plan).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants