[fr] ETRE_VPPA_OU_ADJ_fix #9451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GillouLT
commented
Oct 9, 2023
| @@ -82270,7 +82292,7 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA | |||
| <exception postag="V.* ppa [fe] .*|J [fe] .*|V ppa m sp" postag_regexp="yes"/></token> | |||
| </marker> | |||
| </pattern> | |||
| <message>Le mot masculin « \7 » n’est pas accordé en genre avec le mot féminin « \2 ».</message> | |||
| <message>Vérifiez l'accord en genre et en nombre de « \7 », le féminin semble plus probable.</message> | |||
There was a problem hiding this comment.
« \2 » is in min="0", so in some sentences we had an empty « »
GillouLT
commented
Oct 9, 2023
| @@ -82250,6 +82262,16 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA | |||
| <token min="0" max="4" postag="A"/> | |||
| <token postag="(V ppa|J) m .*" postag_regexp="yes"/> | |||
| </antipattern> | |||
| <antipattern> | |||
| <token postag="UNKNOWN"/> | |||
There was a problem hiding this comment.
The only difference from the pattern is the UNKNOWN tag, with this change, we will prevent the rule from triggering when the gender of the token is also unknown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address: https://github.com/languagetooler-gmbh/languagetool-premium/issues/6459