Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fr] FP_FIX_BATCH2_6459 #9463

Merged
merged 3 commits into from
Oct 12, 2023
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10291,6 +10291,17 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
<example correction="disproportionnée">Il a recours à l'aide <marker>disproportionnés</marker>.</example>
</rule>
<rule>
<antipattern>
<token postag="D.* p" postag_regexp="yes"/>
<token postag="N.* p" postag_regexp="yes"/>
<token>à</token>
<example>Consultez les aides à la formation accessibles aux particuliers.</example>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this AP here, but let's check the diff tomorrow

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can look at the rule in the diff. I think it will solve some Fps in the diff like:
Les crédits à la consommation classiques
un service à la clientèle complet
Les blessures à la main dues à la découpe d'avocats sont courantes 🥑 😨

</antipattern>
<antipattern>
<token>à</token>
<token>la</token>
<token regexp="yes">clé|clef</token>
</antipattern>
<pattern>
<token postag="N.*" postag_regexp="yes"/>
<token>à</token>
Expand All @@ -10316,7 +10327,7 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
<exception postag="[YK]" postag_regexp="yes"/>
</token>
<token postag="N [em] p" postag_regexp="yes">
<exception regexp="yes">fins|politiques|fils|œuvres|tous</exception></token>
<exception regexp="yes">fins|politiques|fils|œuvres|tous|aides</exception></token>
<marker>
<token postag="J.*" postag_regexp="yes">
<exception regexp="yes">telles?|tels?|fin|(?-i)[A-Z].*</exception>
Expand Down Expand Up @@ -50329,6 +50340,11 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
<token postag="V ppa.*|J.*" postag_regexp="yes"/>
</antipattern>
<rule>
<antipattern>
<token postag="V.*" postag_regexp="yes" inflected="yes">répondre</token>
<token regexp="yes">présent|absent</token>
<example>L'entreprise répond présent à toutes les demandes.</example>
</antipattern>
<pattern>
<token postag="C sub|M nonfin|SENT_START" postag_regexp="yes">
<exception scope="previous">ce</exception></token>
Expand Down Expand Up @@ -53573,7 +53589,7 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
<exception>trop</exception></token>
<marker>
<token postag="V ppa.*" postag_regexp="yes" regexp="yes">.*ée?s?$
<exception regexp="yes">expulsée?S?|affectée?s?|assistée?S?|entourée?S?</exception></token>
<exception regexp="yes">expulsée?S?|affectée?s?|assistée?S?|entourée?S?|dotée?s?</exception></token>
</marker>
<token inflected="yes">de</token>
<token postag="D.*" postag_regexp="yes" min="0" max="1"/>
Expand Down Expand Up @@ -92061,7 +92077,7 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
<token postag="V.* inf" postag_regexp="yes" min="0" max="1"/>
</marker>
<token postag="D [em] s" postag_regexp="yes"/>
<token postag="[JN] [em] s" postag_regexp="yes"/>
<token postag="[JN] [em] s" postag_regexp="yes"><exception postag="N f .*" postag_regexp="yes"/></token>
</pattern>
<message>« \1 \2 \3 » n’est pas accordé en nombre avec « \8 ».</message>
<suggestion>quel que <match no="3" postag="V (etre )?(avoir )?(ind|con|sub) (pres|impa|psim|futu) 3 ." postag_regexp="yes" postag_replace="V $1$2$3 $4 3 s"/></suggestion>
Expand Down Expand Up @@ -92137,7 +92153,7 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
<token postag="V.* inf" postag_regexp="yes" min="0" max="1"/>
</marker>
<token postag="D [em] p" postag_regexp="yes"/>
<token postag="[JN] [em] p" postag_regexp="yes"/>
<token postag="[JN] [em] p" postag_regexp="yes"><exception postag="N f .*" postag_regexp="yes"/></token>
</pattern>
<message>« \1 \2 \3 » n’est pas accordé en nombre avec « \8 ».</message>
<suggestion>quels que <match no="3" postag="V (etre )?(avoir )?(ind|con|sub) (pres|impa|psim|futu) 3 ." postag_regexp="yes" postag_replace="V $1$2$3 $4 3 p"/></suggestion>
Expand Down Expand Up @@ -98891,6 +98907,18 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
<token postag="V.*" postag_regexp="yes"/>
<example>Les 19 avions conservé par les Allemands seront démontés en 1942.</example>
</antipattern>
<antipattern>
<token postag="SENT_START.*" postag_regexp="yes"/>
<token regexp="yes" min="0" max="3">[«"]|&quot;</token>
<token regexp="yes">quels?|quelles?</token>
<token min="1" max="4" postag="[ZJN] . (p|sp)|V ppa . p|Y" postag_regexp="yes"/>
<token postag="V.*[123].* s" postag_regexp="yes" regexp="yes">\p{Ll}.*</token>
<token postag="A" min="0" max="3"/>
<token postag="V inf.*" postag_regexp="yes"/>
<token postag="D . s" postag_regexp="yes"/>
<token postag="N . s" postag_regexp="yes"/>
<example>Quels critères doit respecter le moteur pour être commercialisé ?</example>
</antipattern>
<pattern>
<token postag="SENT_START.*" postag_regexp="yes"/>
<token regexp="yes" min="0" max="3">[«"]|&quot;</token>
Expand Down Expand Up @@ -103910,7 +103938,8 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
<token>,</token>
</antipattern>
<pattern>
<token inflected="yes">que</token>
<token inflected="yes">que
<exception scope="previous">ce</exception></token>
<token inflected="yes" min="0" max="3">ne</token>
<token postag="R pers obj.*" postag_regexp="yes" min="0" max="3">
<exception regexp="yes">eux.*|elles</exception></token>
Expand Down Expand Up @@ -104700,6 +104729,14 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
</rule>
</rulegroup>
<rulegroup id="ACCORD_LA_PLUPART_DES" name="Accord avec la plupart des">
<antipattern>
<token postag="D.*" postag_regexp="yes"/>
<token postag="N.*" postag_regexp="yes"/>
<token postag="P"/>
<token>la</token>
<token>plupart</token>
<example>La somme de la plupart des aides varie en fonction du revenu.</example>
</antipattern>
<rule>
<pattern>
<token>la</token>
Expand Down Expand Up @@ -112898,6 +112935,13 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
<token>mais</token>
<token postag="N.*" postag_regexp="yes"/>
</antipattern>
<antipattern>
<token postag="SENT_START"/>
<token>mais</token>
<token postag="N.*" postag_regexp="yes"/>
<token>ne</token>
<example>Mais curiosité ne rime pas avec banalité.</example>
</antipattern>
<pattern>
<marker>
<token>mais</token>
Expand Down